Closed Bug 1840678 Opened 1 year ago Closed 1 year ago

Add API schemas and validate against them before requesting

Categories

(Firefox :: Shopping, task, P2)

Product:
Firefox
Component:
Shopping
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox117 --- fixed

People

(Reporter: fchasen, Assigned: fchasen)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-shopping])

Attachments

(1 file)

Bug 1840678 - Allow Shopping validation to fail by default and update schemas r=#shopping-reviewers
(deleted), text/x-phabricator-request
Details

Currently only the server response is validated against the schema, will need to update to check what the client sends as well.

As there's no assignee, setting to P2 per observation of other Shopping bugs.

Severity: -- → N/A
Priority: -- → P2
Assignee: nobody → fchasen

Thanks :mconley - I opened a bunch of these that I'll check are self-assigned and add priority.

Status: NEW → ASSIGNED
  • Adds request and updated response schemas
  • Adds allowValidationFailure option for ShoppingProduct that default to true
Pushed by fchasen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/83d2865e9b1d Allow Shopping validation to fail by default and update schemas r=jhirsch

https://hg.mozilla.org/mozilla-central/rev/83d2865e9b1d

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox117: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: