Closed Bug 1840843 Opened 1 year ago Closed 1 year ago

`TypeError: can't access property "startsWith", key is undefined` error in the browser console when opening the new migration window with certain browsers profiles as default

Categories

(Firefox :: Migration, defect)

Firefox 116
Desktop
All
defect

Tracking

()

VERIFIED FIXED
116 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox-esr115 --- unaffected
firefox114 --- unaffected
firefox115 --- unaffected
firefox116 --- verified

People

(Reporter: atrif, Assigned: willdurand)

References

(Blocks 4 open bugs)

Details

(Whiteboard: [addons-jira])

Attachments

(3 files)

Found in

  • 116.0a1 (2023-06-28)

Affected versions

  • 116.0a1 (2023-06-28)

Tested platforms

  • Affected platforms: Windows 10x64, macOS 12
  • Unaffected platforms: Ubuntu 22.04

Preconditions

  • browser.migrate.chrome.extensions.enabled: true
  • (maybe?) chrome profile with lots of data (passwords, extensions, history, bookmarks)

Steps to reproduce

  1. Open migration window and observe the browser console.

Expected result

  • No errors are displayed.

Actual result

  • TypeError: can't access property "startsWith", key is undefined _getLocaleString resource:///modules/ChromeMigrationUtils.sys.mjs:146 getExtensionInformation resource:///modules/ChromeMigrationUtils.sys.mjs:110 ChromeMigrationUtils.sys.mjs:127:15 getExtensionInformation resource:///modules/ChromeMigrationUtils.sys.mjs:127 errors are displayed.

Regression range

Additional notes

  • Attached a screen recording.
  • Note that this issue is occurring only on a Windows 10x64 and macOS 12 machine. I can’t reproduce it on Ubuntu 22 or on other Windows 10x64 machine.
  • This also happens when the default browser is Chrome when opening the new migration window.
  • This issue occurs once after a Firefox startup. The issue occurs again only after a Firefox restart or close/reopen.
  • I am not aware of any functionality issues for this error.

:atrif, could you try to find a regression range using for example mozregression?

The bug is caused by the extension not having a description in its manifest.json file, see: https://robwu.nl/crxviewer/?crx=https%3A%2F%2Fchrome.google.com%2Fwebstore%2Fdetail%2Fi-dont-care-about-cookies%2Ffihnjjcciajhdojfnbdddfaoknhalnja%2F

The name is required but the description is not so we should account for that.

I don't think this is a regression since it's a new feature.

Assignee: nobody → wdurand
Status: NEW → ASSIGNED
Assignee: wdurand → nobody
Status: ASSIGNED → NEW
Whiteboard: [addons-jira]
Assignee: nobody → wdurand
Status: NEW → ASSIGNED
Pushed by wdurand@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ff1fb4487754 Handle Chrome extensions without a description in their manifest. r=mconley
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch

Based on comment #0, this bug contains a bisection range found by mozregression. However, the Regressed by field is still not filled.

:willdurand, if possible, could you fill the Regressed by field?

For more information, please visit BugBot documentation.

Flags: needinfo?(wdurand)
Keywords: regression

I don't think that counts as a regression since this is a new feature.

Flags: needinfo?(wdurand)
Keywords: regression

Verified fixed with Firefox 116.0a1 (2023-06-29) on Windows 10x64, macOS 12 and Ubuntu 22.04. I no longer see the error mentioned in the description.
However, an invalid manifest log is displayed on all systems after opening the Migration Window for the first time. Please let me know if this isn't expected and if we should file something against it.

Status: RESOLVED → VERIFIED
Attached image image.png (deleted) —

This is the log.

That debug log statement is indeed expected, thanks!

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: