Open Bug 1841762 Opened 1 year ago Updated 1 year ago

We should always have a valid queryContext in onEngagement

Categories

(Firefox :: Address Bar, task, P3)

Product:
Firefox
Component:
Address Bar
Type:
task

Tracking

()

People

(Reporter: mak, Unassigned)

References

Details

(Whiteboard: [sng-scrubbed][search-tech-debt])

Sometimes queryContext is undefined, my suspect is that it's for the "start" engagement, but should be verified.

Always having a context has some advantages:

  1. it is less error prone
  2. we can use context.isPrivate in the onEngagement implementations instead of inferring it from controller.input
Severity: N/A → S4
Priority: -- → P3
Whiteboard: [sng-scrubbed][search-tech-debt]
You need to log in before you can comment on or make changes to this bug.