Found in

• 116.0b3

Affected versions

• 116.0b3
• 117.0a1 (2023-07-09)

Tested platforms

• Affected platforms: macOS 12
• Unaffected platforms: Windows 11x64,Ubuntu 22.04

Preconditions

• signon.management.page.fileImport.enabled:true
• emty .csv file

Steps to reproduce

1. Import data from Safari.
2. Choose the empty .CSV file from the preconditions.

Expected result

• Chosen data is imported, besides passwords.

Actual result

• Infinite loading and no data is imported.

Regression range

• Not a regression. Reproducible with Firefox 115.0a1 (2023-05-30) after bug 1825874 was implemented.

Additional notes

• Attached a screen recording.
• This also happens when importing a .csv file alone using the Safari option.

:atrif, if you think that's a regression, could you try to find a regression range using for example mozregression?

This also fixes some incorrect inline documentation I found in some of our tests,
and fixes a case where we were showing the warning state for importing bookmarks
in browser_safari_passwords.js.

https://hg.mozilla.org/mozilla-central/rev/14cc087582a1

The patch landed in nightly and beta is affected.
:mconley, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox116 to wontfix.

For more information, please visit BugBot documentation.

This involves a string change, so we'll not uplift.

Verified fixed with Firefox 117.0a1 (2023-07-17) on macOS 12. The infinite loading no longer occurs and the The file doesn't include any valid password data. Pick another file. error is displayed in the import window.