Closed Bug 1842646 Opened 1 year ago Closed 1 year ago

Add a way to disable offering translations

Categories

(Firefox :: Translation, enhancement, P2)

Product:
Firefox
Component:
Translation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
118 Branch
Tracking Flags:
Tracking Status
firefox118 --- fixed

People

(Reporter: gregtatum, Assigned: nordzilla)

References

(Blocks 1 open bug)

Details

Attachments

(7 files)

Bildschirmvideo aufnehmen 2023-08-07 um 16.43.41.mov
(deleted), video/quicktime
Details
WIP: Bug 1842646 - Add a way to disable offering translations; r?nordzilla!
(deleted), text/x-phabricator-request
Details
Bug 1842646 - Refactor clicking settings menu items in Translations tests r=gregtatum!
(deleted), text/x-phabricator-request
Details
Bug 1842646 - Add a way to disable offering translations r=gregtatum!
(deleted), text/x-phabricator-request
Details
Bug 1842646 - Add telemetry for always offer translations r=gregtatum!
(deleted), text/x-phabricator-request
Details
Bug 1842646 - Add tests for disabling offering translations r=gregtatum!
(deleted), text/x-phabricator-request
Details
data-review-request
(deleted), text/plain
chutten
: data-review+
Details

This will go in the gear menu, and about:preferences.

Blocks: 1845180
No longer blocks: 1820214

Oh yes, please!
I am a native German speaker and Firefox now offers me to translate pages from German to English all the time. The "Never translate German" option is greyed out for some reason. That's quite annoying.

(In reply to Nicolai [:Nic] from comment #1)

Oh yes, please!
I am a native German speaker and Firefox now offers me to translate pages from German to English all the time. The "Never translate German" option is greyed out for some reason. That's quite annoying.

Comment to myself: I was able to get rid of these messages by adding my language "de" to browser.translation.neverForLanguages in about:config

@Greg: Have you tried setting browser.translations.enable or browser.translations.automaticallyPopup to false?

Duplicate of this bug: 1847451

Yes, an option to enable/disable or something similar would be very appreciated. Please see how e.g. Chrome is handling this. Thanks.

Refactors interacting with translations panel settings menu items
to more accurately reflect mouse clicks in tests.

Adds functionality to the Translations panel settings
menu for users to disable whether translations will
be automatically offered, i.e. that the translations
panel automatically pops open on relevant web pages.

Co-authored-by: Greg Tatum <tatum.creative@gmail.com>

Depends on D186249

Adds a new telemetry event that corresponds to toggling
the always-offer-translations settings menu item in the
Translations panel.

Depends on D186251

Adds test infrastructure and cases for disabling
and enabling offering translations in the translations
panel.

Co-authored-by: Greg Tatum <tatum.creative@gmail.com>

Depends on D186252

Attachment #9349053 - Attachment description: WIP: Bug 1842646 - Refactor clicking settings menu items in Translations tests → Bug 1842646 - Refactor clicking settings menu items in Translations tests r=gregtatum!
Attachment #9349059 - Attachment description: WIP: Bug 1842646 - Add a way to disable offering translations → Bug 1842646 - Add a way to disable offering translations r=gregtatum!
Attachment #9349060 - Attachment description: WIP: Bug 1842646 - Add telemetry for always offer translations → Bug 1842646 - Add telemetry for always offer translations r=gregtatum!
Attachment #9349061 - Attachment description: WIP: Bug 1842646 - Add tests for disabling offering translations → Bug 1842646 - Add tests for disabling offering translations r=gregtatum!
Assignee: gtatum → enordin
Attached file data-review-request (deleted) —
Attachment #9349264 - Flags: data-review?(chutten)

Comment on attachment 9349264 [details]
data-review-request

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 122.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

Result: datareview+

Attachment #9349264 - Flags: data-review?(chutten) → data-review+
Pushed by gtatum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/266e2808ada7 Refactor clicking settings menu items in Translations tests r=gregtatum https://hg.mozilla.org/integration/autoland/rev/78fb3473267d Add a way to disable offering translations r=gregtatum,fluent-reviewers,flod https://hg.mozilla.org/integration/autoland/rev/11b6d9bed15b Add telemetry for always offer translations r=gregtatum https://hg.mozilla.org/integration/autoland/rev/63a862a6ee50 Add tests for disabling offering translations r=gregtatum
Duplicate of this bug: 1849883
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: