Closed
Bug 18434
Opened 25 years ago
Closed 25 years ago
[Dogfood]Need to implement nsHTTPChannel::OpenInputStream
Categories
(Core :: Networking, defect, P3)
Tracking
()
CLOSED
FIXED
M12
People
(Reporter: warrensomebody, Assigned: jud)
References
Details
(Whiteboard: [PDT+] 12/3)
The jar: protocol now depends on the ability to get a blocking input stream from
all protocols in order to write a jar file to disk. The primary protocol that
needs this is http.
Reporter | ||
Updated•25 years ago
|
Target Milestone: M12
Status: NEW → ASSIGNED
Summary: Need to implement nsHTTPChannel::OpenInputStream for jar: protocol → Need to implement nsHTTPChannel::OpenInputStream
there are other cool reasons too to implement OpenInputStream for HTTP.
Including download which could then pass this stream to a file channel's
AsyncWrite.
Reporter | ||
Comment 2•25 years ago
|
||
That's _exactly_ what the jar: protocol wants to do. I suspect that Bill Law
wants it for saving to disk too, right?
Right, that's what prompted Gagan's comment, I believe. He and I have discussed
this on numerous occasions in the last 2 weeks.
Assignee | ||
Comment 4•25 years ago
|
||
We need this for HTTP save as downloads too. In
this case the unknown content type handler (the save as dialog) needs to be able
to just hand nsFileTransport::AsyncWrite() an input stream (rather than
buffering data then writing it to the nsFileTransport's output stream. This will
allow the unknown content type handler to digest data at a rate fast enough
(actually in time w/) as to not back up the socket transport.
Assignee | ||
Comment 5•25 years ago
|
||
This is dogfood because we need to able to download large files using the save
as dialog.
Assignee | ||
Updated•25 years ago
|
Blocks: 18725
Summary: Need to implement nsHTTPChannel::OpenInputStream → [Dogfood]Need to implement nsHTTPChannel::OpenInputStream
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [PDT+] → [PDT+] 11/26
Assignee | ||
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•25 years ago
|
Status: RESOLVED → REOPENED
Assignee | ||
Comment 8•25 years ago
|
||
fix checked in 11/23/99 2:25pm pac time
Assignee | ||
Comment 9•25 years ago
|
||
whoops re-opening. wrong bug.
Assignee | ||
Updated•25 years ago
|
Status: REOPENED → ASSIGNED
Assignee | ||
Updated•25 years ago
|
Whiteboard: [PDT+] 11/26 → [PDT+] 11/26 awaiting code review
Assignee | ||
Updated•25 years ago
|
Whiteboard: [PDT+] 11/26 awaiting code review → [PDT+] 12/3
Assignee | ||
Comment 11•25 years ago
|
||
got a code review. waiting for green tree.
Assignee | ||
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 12•25 years ago
|
||
fix checked in 11/29/99 8:30pm pac time.
Comment 13•25 years ago
|
||
Jud, what would be a suitable testcase for this bug? Saving a file, using http
upload, using smartupdate, etc? Thanks dude!
Assignee | ||
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 14•25 years ago
|
||
verified
Comment 15•25 years ago
|
||
Marked VERIFED FIXED per valeski. Not testable via QA.
Comment 16•25 years ago
|
||
Bulk move of all Necko (to be deleted component) bugs to new Networking
component.
Updated•25 years ago
|
Status: VERIFIED → REOPENED
Comment 17•25 years ago
|
||
I'm seeing a problem, on both Mac and Linux, where loading a remote stylesheet
(bug 11859), which uses nsHTTPChannel::OpenInputStream(), cause some kind of
threading deadlock, which makes the app cease to respond.
Assignee | ||
Updated•25 years ago
|
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Assignee | ||
Comment 18•25 years ago
|
||
OpenInputStream() is implemented. However it requires that the returned stream
be read on a seperate thread (because the implementation simply uses AsyncRead()
underneath. This needs to be changed. Opening a new bug (22103) that is not
protocol specific.
Updated•25 years ago
|
Status: RESOLVED → CLOSED
Comment 19•25 years ago
|
||
Development issue - Closing
You need to log in
before you can comment on or make changes to this bug.
Description
•