Avoid dispatching DOMActivate for button.click() / checkbox.click(), at least in common cases
Categories
(Core :: DOM: Events, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox118 | --- | fixed |
People
(Reporter: mstange, Assigned: smaug)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sp3])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
About 20% of the time in the testcases in bug 1834003 is spent dispatching a DOMActivate event.
WebKit does not send this event.
|
||
Updated•1 year ago
|
|
Assignee | |
Comment 1•1 year ago
|
||
My plan is to never dispatch DOMActive if there are no listeners. Definitely not trivial change though, currently lots of the default handling is bound to DOMActive.
It seems that those are the DOMActivate event handlers:
|
|
Assignee | |
Updated•1 year ago
|
|
|
Assignee | |
Comment 3•1 year ago
|
||
|
||
Updated•1 year ago
|
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ff0291058601 Don't dispatch DOMActivate if there are no listeners for it, r=masayuki
|
||
Comment 5•1 year ago
|
||
| bugherder | ||
|
||
Comment 6•1 year ago
|
||
appears to be a solid 10% win on AWFY-Speedometer2-Preact-TodoMVC/DeletingItems/Sync (and Preact in general)
https://treeherder.mozilla.org/perfherder/graphs?highlightAlerts=1&highlightChangelogData=1&highlightCommonAlerts=0&selected=3912908,1742845066&series=mozilla-central,3735863,1,13&series=autoland,3912908,1,13&timerange=5184000&zoom=1692127532548,1692496836145,0.9401417323486267,1.6285388388247775
Description
•