Open
Bug 1843475
Opened 1 year ago
Updated 1 year ago
Avoid event type stringification in SessionStoreChangeListener::HandleEvent
Categories
(Core :: DOM: Events, task)
Core
DOM: Events
Tracking
()
ASSIGNED
People
(Reporter: mstange, Assigned: mstange)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sp3])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
This was showing up in the time under the input event in https://share.firefox.dev/3DaKDxI
|
Assignee | |
Updated•1 year ago
|
Whiteboard: [sp3]
|
||
Updated•1 year ago
|
See Also: → https://mozilla-hub.atlassian.net/browse/SP3-442
|
|
Assignee | |
Comment 1•1 year ago
|
||
This showed up in profiles of the checkbox.click() benchmark from bug 1834003.
Before: https://share.firefox.dev/3DaKDxI
After: https://share.firefox.dev/3DecOvS
In the "before" profile, mozilla::dom::Event::GetWidgetEventType was taking
1.9% of the overall time.
|
||
Updated•1 year ago
|
Attachment #9343832 -
Attachment description: Bug 1843475 - Remove event type stringification for click events. r=smaug → Bug 1843475 - Avoid event type stringification in SessionStoreChangeListener::HandleEvent. r=smaug
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/361701efa32d Avoid event type stringification in SessionStoreChangeListener::HandleEvent. r=smaug
|
||
Comment 3•1 year ago
|
||
Backed out for causing mochitests failures in browser_scrollPositions.js
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_scrollPositions.js | scroll is fine - Got "{"children":[{"scroll":"132,372"}]}", expected "{"children":[{"scroll":"132,372"},{"scroll":"475,687"}]}"
|
|
Assignee | |
Comment 4•1 year ago
|
||
Oh, neat!
|
||
Comment 5•1 year ago
|
||
There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:mstange, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.
Flags: needinfo?(smaug)
Flags: needinfo?(mstange.moz)
|
||
Updated•1 year ago
|
Flags: needinfo?(smaug)
|
|
Assignee | |
Updated•1 year ago
|
Flags: needinfo?(mstange.moz)
You need to log in
before you can comment on or make changes to this bug.
Description
•