Closed Bug 1843663 Opened 1 year ago Closed 1 year ago

Remove pre-win-10/11 media queries and styles.

Categories

(Firefox :: Theme, task)

task

Tracking

()

RESOLVED FIXED
117 Branch
Tracking Status
firefox117 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.

Some basic clean-up. I want to do this before doing bigger changes in
bug 1843044.

There's tons more code that can get cleaned-up on the widget side, but
let's start with this.

Duplicate of this bug: 1843223
Blocks: win7-eol
Duplicate of this bug: 1543412
Duplicate of this bug: 1395105
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2a02dfbea569 Remove pre windows-10-specific media queries and styles. r=dao,Gijs,handyman,settings-reviewers
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch

The regressing bug removed:

menuitem:is([type="checkbox"], [checked="true"], [type="radio"]) > .menu-iconic-left > .menu-iconic-icon {
display: none;
}

Because I mistakenly thought it was useless due to:

menuitem[checked="true"] > .menu-iconic-left > .menu-iconic-icon {
display: initial;
}

And the fact that there's no image when not checked. But it's of course
not useless when not checked because we explicitly set the image
dimensions.

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d53dc40a5390 Fix Windows unchecked menuitem styles. r=dao
Regressions: 1846839
Regressions: 1848507
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: