Closed Bug 1843743 Opened 10 months ago Closed 9 months ago

cjk-earthly-branch and cjk-heavenly-stem should fall back to cjk-decimal

Categories

(Core :: Layout: Generated Content, Lists, and Counters, defect)

defect

Tracking

()

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: twisniewski, Assigned: twisniewski)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The severity field is not set for this bug.
:emilio, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(emilio)
Component: CSS Parsing and Computation → Layout: Generated Content, Lists, and Counters
Flags: needinfo?(emilio) → needinfo?(twisniewski)

Xidorn, not sure if you have time to look at this, it's probably something easy or a bogus test, but I'd have to dig more to figure out and not have the cycles r/n.

Flags: needinfo?(xidorn+moz)

They are defined here in the code: https://searchfox.org/mozilla-central/rev/e4fa79ba05364da0d6ec40d3f9dbe0d15ce6f902/layout/style/res/counterstyles.css#171-183

Their system in our impl is alphabetic but in the spec it is fixed, which causes different behavior when out of the given range. The spec was changed on this in https://github.com/w3c/csswg-drafts/pull/4570 which happens after the last update to our impl.

To fix it we simply need to update the system as per the spec.

Flags: needinfo?(xidorn+moz)

Thanks, Xidorn. Confirmed that just that trivial change does the trick. I've got a patch together; just giving it a quick try-run now.

Assignee: nobody → twisniewski
Status: NEW → ASSIGNED
Pushed by twisniewski@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e6bfaa522954
have cjk-earthly-branch and cjk-heavenly-stem use system:fixed to match the latest spec; r=xidorn,emilio
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: