cjk-earthly-branch and cjk-heavenly-stem should fall back to cjk-decimal
Categories
(Core :: Layout: Generated Content, Lists, and Counters, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox118 | --- | fixed |
People
(Reporter: twisniewski, Assigned: twisniewski)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Webkit 174 should fix their implementation. See here: https://bugs.webkit.org/show_bug.cgi?id=258447
Fixing this would let pass two WPTs:
Comment 1•9 months ago
|
||
The severity field is not set for this bug.
:emilio, could you have a look please?
For more information, please visit BugBot documentation.
Comment 2•9 months ago
|
||
They already do, what am I missing? https://searchfox.org/mozilla-central/rev/4e7b319091f2f9eddde7bb6810918dd5de23b709/layout/style/res/counterstyles.css#171,174,178,181
Assignee | ||
Comment 3•9 months ago
|
||
I'm not sure, it might even be a buggy WPT leading to different renderings:
Comment 4•9 months ago
|
||
Xidorn, not sure if you have time to look at this, it's probably something easy or a bogus test, but I'd have to dig more to figure out and not have the cycles r/n.
Comment 5•9 months ago
|
||
They are defined here in the code: https://searchfox.org/mozilla-central/rev/e4fa79ba05364da0d6ec40d3f9dbe0d15ce6f902/layout/style/res/counterstyles.css#171-183
Their system
in our impl is alphabetic
but in the spec it is fixed
, which causes different behavior when out of the given range. The spec was changed on this in https://github.com/w3c/csswg-drafts/pull/4570 which happens after the last update to our impl.
To fix it we simply need to update the system
as per the spec.
Assignee | ||
Comment 6•9 months ago
|
||
Thanks, Xidorn. Confirmed that just that trivial change does the trick. I've got a patch together; just giving it a quick try-run now.
Assignee | ||
Comment 7•9 months ago
|
||
Ok, my mach try auto run is as clean as expected: https://treeherder.mozilla.org/jobs?repo=try&revision=d2bfce408b5bbd75bd1aed40ba7be597c8facb51
Assignee | ||
Comment 8•9 months ago
|
||
Updated•9 months ago
|
Pushed by twisniewski@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e6bfaa522954 have cjk-earthly-branch and cjk-heavenly-stem use system:fixed to match the latest spec; r=xidorn,emilio
Comment 10•9 months ago
|
||
bugherder |
Description
•