Closed
Bug 1844195
Opened 1 year ago
Closed 1 year ago
Avoid duplicating display definitions in rust and C++.
Categories
(Core :: CSS Parsing and Computation, task)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
117 Branch
| Tracking | Status | |
|---|---|---|
| firefox117 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
No description provided.
|
Assignee | |
Comment 1•1 year ago
|
||
We need to inline Self::new() so cbindgen generates the constants, which
is kinda lame, but seems better than duplicating the values and type
definitions.
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a3f2d5937c4
Avoid duplicating rust and C++ display definitions. r=layout-reviewers,jfkthame
|
|
Assignee | |
Updated•1 year ago
|
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f3394bd0f554
Avoid duplicating rust and C++ display definitions. r=layout-reviewers,jfkthame
Backout by imoraru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9a254411906
Backed out changeset f3394bd0f554 for causing conflicts with another backout.
|
||
Comment 6•1 year ago
|
||
Sorry :emilio for this backout, but there were some conflicts when I tried to backout this https://bugzilla.mozilla.org/show_bug.cgi?id=1829016#c10 . I hope this doesn't cause too much trouble for you.
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/883827ba870e
Avoid duplicating rust and C++ display definitions. r=layout-reviewers,jfkthame
|
||
Comment 9•1 year ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox117:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•