Closed
Bug 1844665
Opened 1 year ago
Closed 1 year ago
Access shopping.html as an about page to ensure it loads in the privileged about process
Categories
(Firefox :: Shopping, task, P1)
Tracking
()
RESOLVED
FIXED
117 Branch
| Tracking | Status | |
|---|---|---|
| firefox117 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fidefe-shopping])
Attachments
(3 files)
Per discussion with Nika, we can't really have a system privileged chrome URL load in a content process, it upsets various things that try to prevent that happening, like the assertion failure Katherine ran into in https://phabricator.services.mozilla.com/D183917#inline-1020546 .
The solution is basically to:
- create an about: page (hidden from about:about, loading in the privileged about process)
- ensure it loads in the privileged about process
- set the XUL
<browser>up withremoteType="privilegedabout"as well asmaychangeremoteness=trueso that any loads are guaranteed to pick the correct process - doublecheck the actors load and tests still pass (esp. all files referenced, as the about: page reference may change that)
|
||
Updated•1 year ago
|
|
Assignee | |
Comment 1•1 year ago
|
||
|
|
Assignee | |
Comment 2•1 year ago
|
||
Depends on D184742
|
|
Assignee | |
Comment 3•1 year ago
|
||
Depends on D184743
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/af4999afee01
rename RPMSetBoolPref so it's more obvious you can use it for int/char prefs, r=jhirsch
https://hg.mozilla.org/integration/autoland/rev/c3a64755c336
make reusable components OK with living in unprivileged documents, r=hjones
https://hg.mozilla.org/integration/autoland/rev/c3c3a8d398dc
use about: page for shopping to ensure process mechanics make sense, r=jhirsch,nika
|
||
Comment 5•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/af4999afee01
https://hg.mozilla.org/mozilla-central/rev/c3a64755c336
https://hg.mozilla.org/mozilla-central/rev/c3c3a8d398dc
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
Duplicate of this bug: 1845598
No longer duplicate of this bug: 1845598
You need to log in
before you can comment on or make changes to this bug.
Description
•