Closed
Bug 1844908
Opened 1 year ago
Closed 1 year ago
Remove pre-Win10-specific codepath
Categories
(Core :: General, task)
Core
General
Tracking
()
RESOLVED
FIXED
118 Branch
| Tracking | Status | |
|---|---|---|
| firefox118 | --- | fixed |
People
(Reporter: emk, Assigned: emk)
References
(Blocks 2 open bugs)
Details
Attachments
(22 files)
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details |
No description provided.
|
Assignee | |
Comment 1•1 year ago
|
||
|
||
Updated•1 year ago
|
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•1 year ago
|
||
Depends on D184287
|
|
Assignee | |
Comment 3•1 year ago
|
||
Depends on D184288
|
|
Assignee | |
Comment 4•1 year ago
|
||
Depends on D184289
|
|
Assignee | |
Comment 5•1 year ago
|
||
Depends on D184291
|
|
Assignee | |
Comment 6•1 year ago
|
||
Depends on D184292
|
|
Assignee | |
Comment 7•1 year ago
|
||
Depends on D184293
|
|
Assignee | |
Comment 8•1 year ago
|
||
Depends on D184294
|
|
Assignee | |
Comment 9•1 year ago
|
||
Depends on D184295
|
|
Assignee | |
Comment 10•1 year ago
|
||
Depends on D184296
|
|
Assignee | |
Comment 11•1 year ago
|
||
Depends on D184297
|
|
Assignee | |
Comment 12•1 year ago
|
||
Depends on D184298
|
|
Assignee | |
Comment 13•1 year ago
|
||
Depends on D184299
|
|
Assignee | |
Comment 14•1 year ago
|
||
Depends on D184300
|
|
Assignee | |
Comment 15•1 year ago
|
||
Depends on D184301
|
|
Assignee | |
Comment 16•1 year ago
|
||
Depends on D184302
|
|
Assignee | |
Comment 17•1 year ago
|
||
Depends on D184303
|
|
Assignee | |
Comment 18•1 year ago
|
||
Depends on D184304
|
|
Assignee | |
Comment 19•1 year ago
|
||
Depends on D184305
|
|
Assignee | |
Comment 20•1 year ago
|
||
Depends on D184306
|
|
Assignee | |
Comment 21•1 year ago
|
||
Depends on D184307
|
|
Assignee | |
Comment 22•1 year ago
|
||
Depends on D184308
|
|
||
Updated•1 year ago
|
Attachment #9345178 -
Attachment description: Bug 1844908 - Remove pre-Win10-specific codepath from security/sandbox/win/. r?bobowen → Bug 1844908 - Remove pre-Win10-specific codepath from security/sandbox/win/.
|
||
Comment 23•1 year ago
|
||
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/945ccbedde0b
Remove pre-Win10-specific codepath from browser/app/winlauncher/. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/e9a0f1c6760c
Remove pre-Win10-specific codepath from browser/components/shell/. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/b2c5636df673
Remove pre-Win10-specific codepath from dom/media/. r=alwu
https://hg.mozilla.org/integration/autoland/rev/ab50c6c5425a
Remove pre-Win10-specific codepath from hal/. r=gsvelto
https://hg.mozilla.org/integration/autoland/rev/3c59143f8dd7
Remove pre-Win10-specific codepath from OSPreferences. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/3d961cf25afe
Remove pre-Win10-specific codepath from ipc/. r=ipc-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/7eca452f5fd7
Remove pre-Win10-specific codepath from memory/. r=glandium
https://hg.mozilla.org/integration/autoland/rev/2b3d2df94db3
Remove pre-Win10-specific codepath from mozglue/. r=glandium
https://hg.mozilla.org/integration/autoland/rev/2fa203969ec5
Remove pre-Win10-specific codepath from security/manager/. r=keeler
https://hg.mozilla.org/integration/autoland/rev/af84e701d616
Remove pre-Win10-specific codepath from security/sandbox/win/. r=bobowen
https://hg.mozilla.org/integration/autoland/rev/2b419fabf1e8
Remove pre-Win10-specific codepath from toolkit/components/parentalcontrols/. r=handyman
https://hg.mozilla.org/integration/autoland/rev/4b6fe8a4e7db
Remove pre-Win10-specific codepath from toolkit/crashreporter/. r=gsvelto
https://hg.mozilla.org/integration/autoland/rev/8d715131510f
Remove pre-Win10-specific codepath from toolkit/mozapps/defaultagent/. r=nrishel
https://hg.mozilla.org/integration/autoland/rev/6dc7646d1ffa
Remove pre-Win10-specific codepath from toolkit/system/windowsPackageManager/. r=bhearsum,nrishel
https://hg.mozilla.org/integration/autoland/rev/7f1e0a527839
Remove pre-Win10-specific codepath from DLL Blocklist Services. r=gstoll
https://hg.mozilla.org/integration/autoland/rev/a1414db64e33
Remove pre-Win10-specific codepath from Gecko Profiler. r=mstange
https://hg.mozilla.org/integration/autoland/rev/225dc3aeb220
Remove pre-Win10-specific codepath from uriloader/exthandler/. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/a8010ff534bf
Remove pre-Win10-specific codepath from widget/. r=handyman
https://hg.mozilla.org/integration/autoland/rev/44c66f2233cf
Remove pre-Win10-specific codepath from xpcom/. r=emilio
|
|
Assignee | |
Updated•1 year ago
|
Keywords: leave-open
|
||
Comment 24•1 year ago
|
||
Backed out for causing win bustage on AvailableMemoryTracker.cpp
- backout: https://hg.mozilla.org/integration/autoland/rev/32c4cdc2f94f584c64e06001817e43779b12d5e5
- push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=44c66f2233cfcdfa9e3c70e71ea82d2e4f0c4ae9
- failure log: https://treeherder.mozilla.org/logviewer?job_id=423827132&repo=autoland&lineNumber=66164
[task 2023-07-25T16:21:46.454Z] 16:21:46 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang-cl -fms-compatibility-version=19.29 -Xclang -std=c++17 -Xclang -ivfsoverlay -Xclang /builds/worker/fetches/vs/overlay.yaml -FoAvailableMemoryTracker.obj -c -I/builds/worker/workspace/obj-build/dist/stl_wrappers -guard:cf -DNDEBUG=1 -DTRIMMED=1 -DMOZ_PHC -DUNICODE -D_UNICODE -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_SECURE_ATL -DCHROMIUM_BUILD [........]
[task 2023-07-25T16:21:46.454Z] 16:21:46 ERROR - /builds/worker/checkouts/gecko/xpcom/base/AvailableMemoryTracker.cpp(40,14): error: unknown type name 'HEAP_INFORMATION_CLASS'
[task 2023-07-25T16:21:46.454Z] 16:21:46 INFO - static const HEAP_INFORMATION_CLASS HeapOptimizeResources =
[task 2023-07-25T16:21:46.454Z] 16:21:46 INFO - ^
[task 2023-07-25T16:21:46.454Z] 16:21:46 ERROR - /builds/worker/checkouts/gecko/xpcom/base/AvailableMemoryTracker.cpp(41,17): error: unknown type name 'HEAP_INFORMATION_CLASS'
[task 2023-07-25T16:21:46.454Z] 16:21:46 INFO - static_cast<HEAP_INFORMATION_CLASS>(3);
[task 2023-07-25T16:21:46.454Z] 16:21:46 INFO - ^
[task 2023-07-25T16:21:46.455Z] 16:21:46 ERROR - /builds/worker/checkouts/gecko/xpcom/base/AvailableMemoryTracker.cpp(43,14): error: unknown type name 'DWORD'
[task 2023-07-25T16:21:46.455Z] 16:21:46 INFO - static const DWORD HEAP_OPTIMIZE_RESOURCES_CURRENT_VERSION = 1;
[task 2023-07-25T16:21:46.455Z] 16:21:46 INFO - ^
[task 2023-07-25T16:21:46.455Z] 16:21:46 ERROR - /builds/worker/checkouts/gecko/xpcom/base/AvailableMemoryTracker.cpp(46,3): error: unknown type name 'DWORD'
[task 2023-07-25T16:21:46.455Z] 16:21:46 INFO - DWORD Version;
[task 2023-07-25T16:21:46.455Z] 16:21:46 INFO - ^
[task 2023-07-25T16:21:46.455Z] 16:21:46 ERROR - /builds/worker/checkouts/gecko/xpcom/base/AvailableMemoryTracker.cpp(47,3): error: unknown type name 'DWORD'
[task 2023-07-25T16:21:46.455Z] 16:21:46 INFO - DWORD Flags;
[task 2023-07-25T16:21:46.455Z] 16:21:46 INFO - ^
[task 2023-07-25T16:21:46.456Z] 16:21:46 ERROR - /builds/worker/checkouts/gecko/xpcom/base/AvailableMemoryTracker.cpp(121,5): error: no member named 'HeapSetInformation' in the global namespace
[task 2023-07-25T16:21:46.456Z] 16:21:46 INFO - ::HeapSetInformation(nullptr, HeapOptimizeResources, &heapOptInfo,
[task 2023-07-25T16:21:46.456Z] 16:21:46 INFO - ~~^
[task 2023-07-25T16:21:46.456Z] 16:21:46 INFO - 6 errors generated.
[task 2023-07-25T16:21:46.456Z] 16:21:46 ERROR - gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:659: AvailableMemoryTracker.obj] Error 1
Flags: needinfo?(VYV03354)
|
|
||
Comment 25•1 year ago
|
||
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/e10517908401
Remove pre-Win10-specific codepath from browser/app/winlauncher/. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/ba1f4b46cfe0
Remove pre-Win10-specific codepath from browser/components/shell/. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/3b13fa0a884b
Remove pre-Win10-specific codepath from dom/media/. r=alwu
https://hg.mozilla.org/integration/autoland/rev/98708293466c
Remove pre-Win10-specific codepath from hal/. r=gsvelto
https://hg.mozilla.org/integration/autoland/rev/c9ce1689b930
Remove pre-Win10-specific codepath from OSPreferences. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/1afb85364825
Remove pre-Win10-specific codepath from ipc/. r=ipc-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/97ed65018c5e
Remove pre-Win10-specific codepath from memory/. r=glandium
https://hg.mozilla.org/integration/autoland/rev/03b7634f14b2
Remove pre-Win10-specific codepath from mozglue/. r=glandium
https://hg.mozilla.org/integration/autoland/rev/12fd36fc1392
Remove pre-Win10-specific codepath from security/manager/. r=keeler
https://hg.mozilla.org/integration/autoland/rev/4ed19723fa92
Remove pre-Win10-specific codepath from security/sandbox/win/. r=bobowen
https://hg.mozilla.org/integration/autoland/rev/e24ea8d8f4e5
Remove pre-Win10-specific codepath from toolkit/components/parentalcontrols/. r=handyman
https://hg.mozilla.org/integration/autoland/rev/a169598b79ec
Remove pre-Win10-specific codepath from toolkit/crashreporter/. r=gsvelto
https://hg.mozilla.org/integration/autoland/rev/a4cf30200f7c
Remove pre-Win10-specific codepath from toolkit/mozapps/defaultagent/. r=nrishel
https://hg.mozilla.org/integration/autoland/rev/c14cfd2a196d
Remove pre-Win10-specific codepath from toolkit/system/windowsPackageManager/. r=bhearsum,nrishel
https://hg.mozilla.org/integration/autoland/rev/0aa3d4000274
Remove pre-Win10-specific codepath from DLL Blocklist Services. r=gstoll
https://hg.mozilla.org/integration/autoland/rev/b6f259c805c9
Remove pre-Win10-specific codepath from Gecko Profiler. r=mstange
https://hg.mozilla.org/integration/autoland/rev/e7fc6f27c9da
Remove pre-Win10-specific codepath from uriloader/exthandler/. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/828ced26aaec
Remove pre-Win10-specific codepath from widget/. r=handyman
https://hg.mozilla.org/integration/autoland/rev/087b6497aae8
Remove pre-Win10-specific codepath from xpcom/. r=emilio
|
|
Assignee | |
Updated•1 year ago
|
Flags: needinfo?(VYV03354)
|
||
Comment 26•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e10517908401
https://hg.mozilla.org/mozilla-central/rev/ba1f4b46cfe0
https://hg.mozilla.org/mozilla-central/rev/3b13fa0a884b
https://hg.mozilla.org/mozilla-central/rev/98708293466c
https://hg.mozilla.org/mozilla-central/rev/c9ce1689b930
https://hg.mozilla.org/mozilla-central/rev/1afb85364825
https://hg.mozilla.org/mozilla-central/rev/97ed65018c5e
https://hg.mozilla.org/mozilla-central/rev/03b7634f14b2
https://hg.mozilla.org/mozilla-central/rev/12fd36fc1392
https://hg.mozilla.org/mozilla-central/rev/4ed19723fa92
https://hg.mozilla.org/mozilla-central/rev/e24ea8d8f4e5
https://hg.mozilla.org/mozilla-central/rev/a169598b79ec
https://hg.mozilla.org/mozilla-central/rev/a4cf30200f7c
https://hg.mozilla.org/mozilla-central/rev/c14cfd2a196d
https://hg.mozilla.org/mozilla-central/rev/0aa3d4000274
https://hg.mozilla.org/mozilla-central/rev/b6f259c805c9
https://hg.mozilla.org/mozilla-central/rev/e7fc6f27c9da
https://hg.mozilla.org/mozilla-central/rev/828ced26aaec
https://hg.mozilla.org/mozilla-central/rev/087b6497aae8
|
|
||
Comment 27•1 year ago
|
||
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/1102d2a280ed
Remove pre-Win10-specific codepath from gfx/. r=gfx-reviewers,nical
|
||
Comment 28•1 year ago
|
||
| bugherder | ||
|
|
||
Comment 29•1 year ago
|
||
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/645b30285cd0
Remove pre-Win10-specific codepath from Media Transport. r=bwc,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/b09cf8792481
Remove unused Windows version check functions. r=handyman
|
|
Assignee | |
Updated•1 year ago
|
Keywords: leave-open
|
||
Comment 30•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/645b30285cd0
https://hg.mozilla.org/mozilla-central/rev/b09cf8792481
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox118:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•