Closed Bug 1845017 Opened 1 year ago Closed 1 year ago

Intermittent PHC.TestPHCExhaustion | Value of: GetPHCAllocation(128)

Categories

(Core :: Memory Allocator, defect, P5)

defect

Tracking

()

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: pbone)

References

(Blocks 2 open bugs)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Flags: needinfo?(pbone)

I'm fairly sure what's happening is that we do not correctly use up all the allocations. Most are used but some are freed but their reuse delay has not yet expired so PHC refuses to allocate them during the initial part of the test.

Then on line 361 we continue to hammer PHC and a page's reuse delay ends and it successfully allocates a page and our test fails.

This is benign, but an annoying intermittent. To fix it we will want to be able to set PHC's parameters at runtime and decrease the reuse delay during this test.

Assignee: nobody → pbone
Status: NEW → ASSIGNED
Flags: needinfo?(pbone)

I asked noemi_erli about this, they found that there's another crash that might suggest this test is broken anyway, or at least not always working.

https://treeherder.mozilla.org/logviewer?job_id=423880091&repo=autoland&lineNumber=2029

For now I'll disable the test so it doesn't bother anyone and fix it properly later.

Blocks: 1845655
Blocks: PHC2023
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/fcd8eecfa7b1 Disable the TestPHCExhaustion test r=glandium

Backed out for causing build bustages in TestPHC.cpp

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: /builds/worker/checkouts/gecko/memory/replace/phc/test/gtest/TestPHC.cpp(341,36): error: code will never be executed [-Werror,-Wunreachable-code]
Flags: needinfo?(pbone)
Flags: needinfo?(pbone)
Pushed by pbone@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5c2d20e990ab Disable the TestPHCExhaustion test r=glandium
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: