Closed
Bug 1845256
Opened 1 year ago
Closed 1 year ago
Avoid re-hashing the same string contents twice when deduping strings
Categories
(Core :: JavaScript: GC, enhancement, P1)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
117 Branch
| Tracking | Status | |
|---|---|---|
| firefox117 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sp3])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The profile from bug 1844868 shows that the same string contents are hashed twice in TenuringTracer::moveToTenured(JSString*).
|
Assignee | |
Updated•1 year ago
|
Component: JavaScript Engine → JavaScript: GC
|
|
Assignee | |
Comment 1•1 year ago
|
||
Pushed by andre.bargull@gmail.com: https://hg.mozilla.org/integration/autoland/rev/8ea7aa580b52 Avoid re-hashing the same string contents twice when deduping strings. r=jonco
|
||
Comment 3•1 year ago
|
||
Backed out for causing bustage on Tenuring.cpp
- backout: https://hg.mozilla.org/integration/autoland/rev/8488d4ccc99c5c9e416f9e992b0ee476b1731377
- push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=GlLZfuPMSke8DhLKx4iTFg.0&revision=8ea7aa580b526bc8c4a486b95f73da88462f716d
- failure log: https://treeherder.mozilla.org/logviewer?job_id=423786756&repo=autoland&lineNumber=4754
[task 2023-07-25T10:13:53.834Z] In file included from Unified_cpp_js_src_gc3.cpp:20:
[task 2023-07-25T10:13:53.834Z] /builds/worker/checkouts/gecko/js/src/gc/Tenuring.cpp:769:11: error: unused type alias 'DedupStringHasher' [-Werror,-Wunused-local-typedef]
[task 2023-07-25T10:13:53.834Z] using DedupStringHasher = DeduplicationStringHasher<JSString*>;
[task 2023-07-25T10:13:53.834Z] ^
[task 2023-07-25T10:13:53.834Z] 1 error generated.
[task 2023-07-25T10:13:53.834Z] gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:660: Unified_cpp_js_src_gc3.o] Error 1
Flags: needinfo?(andrebargull)
|
|
Assignee | |
Updated•1 year ago
|
Flags: needinfo?(andrebargull)
Pushed by andre.bargull@gmail.com: https://hg.mozilla.org/integration/autoland/rev/3bd0ed894cf9 Avoid re-hashing the same string contents twice when deduping strings. r=jonco
|
||
Updated•1 year ago
|
Severity: -- → N/A
Priority: -- → P1
|
||
Comment 5•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
|
||
Updated•1 year ago
|
Whiteboard: [sp3]
|
||
Updated•1 year ago
|
See Also: → https://mozilla-hub.atlassian.net/browse/SP3-482
You need to log in
before you can comment on or make changes to this bug.
Description
•