`selectMessage` function in about:3pane could select a message in the wrong folder
Categories
(Thunderbird :: Folder and Message Lists, defect, P2)
Tracking
(thunderbird_esr102 unaffected, thunderbird_esr115 fixed, thunderbird117 fixed)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr102 | --- | unaffected |
| thunderbird_esr115 | --- | fixed |
| thunderbird117 | --- | fixed |
People
(Reporter: darktrojan, Assigned: darktrojan)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
rjl
:
approval-comm-esr115+
|
Details |
The selectMessage function looks for the message in the message list and selects it. If the message isn't found, we change to the message's folder and try again. However we use findIndexOfMsgHdr to find the message, and that only compares message keys. Two messages in different folders can have the same key, so we could find the right message key in the wrong folder and select that message instead.
|
Assignee | |
Comment 1•1 year ago
|
||
|
||
Updated•1 year ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/e2b25851c9b6
Fix selectMessage when a change of folder is required. r=mkmelin
|
|
Assignee | |
Updated•1 year ago
|
|
|
Assignee | |
Comment 3•1 year ago
|
||
Comment on attachment 9347064 [details]
Bug 1846885 - Fix selectMessage when a change of folder is required. r=#thunderbird-reviewers
[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: wrong message can get selected without any apparent reason
Testing completed (on c-c, etc.): landed a week ago
Risk to taking this patch (and alternatives if risky): low
|
|
||
Comment 4•1 year ago
|
||
Comment on attachment 9347064 [details]
Bug 1846885 - Fix selectMessage when a change of folder is required. r=#thunderbird-reviewers
[Triage Comment]
Approved for beta
|
||
Comment 5•1 year ago
|
||
| bugherder uplift | ||
Thunderbird 117.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/4c5a8c840395
|
||
Comment 6•1 year ago
|
||
Comment on attachment 9347064 [details]
Bug 1846885 - Fix selectMessage when a change of folder is required. r=#thunderbird-reviewers
[Triage Comment]
Marked as blocking bug 1845011 which has failing tests on comm-esr115 currently. Uplifting this bug seems to fix those failures.
|
|
||
Comment 7•1 year ago
|
||
| bugherder uplift | ||
Thunderbird 115.2.0:
https://hg.mozilla.org/releases/comm-esr115/rev/ffd49506d62c
Description
•