Closed Bug 1846936 Opened 1 year ago Closed 1 year ago

[loong64][mips64] Implement wasm tail calls

Categories

(Core :: JavaScript Engine: JIT, defect)

Other
Unspecified
defect

Tracking

()

RESOLVED FIXED
118 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox-esr115 --- unaffected
firefox116 --- unaffected
firefox117 --- unaffected
firefox118 --- fixed

People

(Reporter: zhaojiazhong-hf, Assigned: zhaojiazhong-hf)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Failed to build js on loongarch64 and mips64 platform after one patch of bug 1571998, which introduced a new function MacroAssembler::freeStackTo that needs to be ported:

js/src/jit/CodeGenerator.cpp:8968:12: error: attempt to use a deleted function
masm.freeStackTo(masm.framePushed());
js/src/jit/MacroAssembler.h:588:8: note: 'freeStackTo' has been explicitly marked deleted here
void freeStackTo(uint32_t framePushed) DEFINED_ON(x86_shared, arm, arm64);

Blocks: 1757272, 1639895
Keywords: regression
Regressed by: 1571998

Port masm.freeStackTo to loongarch64 and mips64 platform.

Assignee: nobody → zhaojiazhong-hf
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by ydelendik@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8c37f2aefe55 [loong64][mips64] Implement function masm.freeStackTo. r=yury
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch

I'm sorry that I didn't notice there is another patch of bug 1571998 needs to be ported to loong64 and mips64 platform.
And since they are both for wasm tail call feature, so I think I should reopen this issue, and change the summary.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: [loong64][mips64] Failed to build js (attempt to use a deleted function masm.freeStackTo) → [loong64][mips64] Implement wasm tail calls
Pushed by ydelendik@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e8c6dc4a318c [loong64][mips64] Port wasm return calls implementation. r=yury
Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: