Closed Bug 1847150 Opened 1 year ago Closed 1 year ago

Add more helpful event keys to TranslationsTelemetry

Categories

(Firefox :: Translation, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
118 Branch
Tracking Status
firefox117 --- fixed
firefox118 --- fixed

People

(Reporter: nordzilla, Assigned: nordzilla)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Adds a few more event keys to TranslationsTelemetry on the panel open event and the translation_request event.

Adds a few more event keys to the panel open event, such as the
detected document language tag, and whether the panel was opened
automatically or manually.

Adds a few more event keys to the translation_request event,
such as the top preferred language, and the detected document
language tag.

Depends on D185386

Attachment #9347311 - Attachment description: WIP: Bug 1847150 - Add more TranslationsTelemetry event keys for panel open → Bug 1847150 - Add more TranslationsTelemetry event keys for panel open r=gregtatum!
Attachment #9347312 - Attachment description: WIP: Bug 1847150 - Add more TranslationsTelemetry event keys for translation_request → Bug 1847150 - Add more TranslationsTelemetry event keys for translation_request r=gregtatum!
Attached file data-review-request (deleted) —

:chutten

This patch adds the following event keys to pre-existing events in the metrics.yaml

translations.translation_request#document_language      
    | interaction 
    | The detected BCP-47 language tag of the document.                   

translations.translation_request#top_preferred_language 
    | interaction 
    | The top preferred language for this user.                         

translations_panel.open#auto_show                       
    | interaction 
    | Whether the panel was opened automatically or manually by the user.

translations_panel.open#view_name                       
    | interaction 
    | The type of view shown in the panel.

translations_panel.open#document_language
    | interaction 
    | The detected BCP-47 language tag of the document.
Attachment #9347451 - Flags: data-review?(chutten)

Comment on attachment 9347451 [details]
data-review-request

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 122.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.


Result: datareview+

Attachment #9347451 - Flags: data-review?(chutten) → data-review+
Pushed by enordin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/017b6a8a98d9 Add more TranslationsTelemetry event keys for panel open r=gregtatum https://hg.mozilla.org/integration/autoland/rev/8bfa768bb965 Add more TranslationsTelemetry event keys for translation_request r=gregtatum
Regressions: 1847339
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch

Comment on attachment 9347311 [details]
Bug 1847150 - Add more TranslationsTelemetry event keys for panel open r=gregtatum!

Beta/Release Uplift Approval Request

  • User impact if declined:
    We will not have the full scope of desired telemetry data on the initial release of the feature, which may make it more difficult to make informed product decisions about the release.
  • Is this code covered by automated tests?:
    Yes
  • Has the fix been verified in Nightly?:
    Yes
  • Needs manual test from QE?:
    No
  • If yes, steps to reproduce:
  • List of other uplifts needed:
    None
  • Risk to taking this patch:
    Medium
  • Why is the change risky/not risky? (and alternatives if risky):
    Telemetry is considered medium risk based on the following guidelines:
    https://wiki.mozilla.org/Release_Management/Uplift_rules
    I do not believe this to be a risky change as no new metrics were added. This patch only adds more key/value pairs to existing metrics.
    We are also fairly early in the beta process, which I feel decreases the risk.
  • String changes made/needed:
    None
  • Is Android affected?:
    No
Attachment #9347311 - Flags: approval-mozilla-beta?
Attachment #9347312 - Flags: approval-mozilla-beta?

Comment on attachment 9347311 [details]
Bug 1847150 - Add more TranslationsTelemetry event keys for panel open r=gregtatum!

Approved for 117.0b6

Attachment #9347311 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9347312 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: