Closed
Bug 1847818
Opened 1 year ago
Closed 1 year ago
restore aec logging from about:webrtc lost in libwebrtc v86 import
Categories
(Core :: WebRTC, defect, P2)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
118 Branch
People
(Reporter: mjf, Assigned: mjf)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
We lost the ability to capture aec logging during the import of libwebrtc v86 when apm_debug_dump was reset to false in third_party/libwebrc/webrtc.gni. A few other changes are necessary to correct build issues now that code in apm_data_dumper.{cc|h} is building again.
|
Assignee | |
Updated•1 year ago
|
Assignee: nobody → mfroman
Severity: -- → S3
Keywords: regression
Priority: -- → P2
Regressed by: 1654112
|
||
Comment 1•1 year ago
|
||
Set release status flags based on info from the regressing bug 1654112
status-firefox116:
--- → affected
status-firefox117:
--- → affected
status-firefox118:
--- → affected
status-firefox-esr102:
--- → affected
status-firefox-esr115:
--- → affected
|
|
Assignee | |
Comment 2•1 year ago
|
||
|
|
Assignee | |
Comment 3•1 year ago
|
||
Depends on D185709
Pushed by mfroman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a67a9e51d8b8 restore aec logging from about:webrtc. r=ng,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/ba9868b3f4e7 restore aec logging from about:webrtc - moz.build file updates. r=ng,webrtc-reviewers
|
||
Comment 5•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a67a9e51d8b8
https://hg.mozilla.org/mozilla-central/rev/ba9868b3f4e7
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
|
|
||
Comment 6•1 year ago
|
||
The patch landed in nightly and beta is affected.
:mjf, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox117towontfix.
For more information, please visit BugBot documentation.
Flags: needinfo?(mfroman)
|
|
Assignee | |
Comment 7•1 year ago
|
||
This is a rarely used feature that requires advanced knowledge to use effectively. I don't think it is needs uplift.
Flags: needinfo?(mfroman)
|
||
Updated•1 year ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•