Open
Bug 1848004
Opened 9 months ago
Updated 9 months ago
Refactor event type code in XMLHttpRequest code
Categories
(Core :: DOM: Core & HTML, task)
Core
DOM: Core & HTML
Tracking
()
ASSIGNED
People
(Reporter: twisniewski, Assigned: twisniewski)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
We can improve the way we handle passing around and identifying readystatechange and progress events in the XMLHttpRequest classes to reduce technical debt.
- Factor out the enums and string constants into the base XMLHttpRequest class.
- Add a few helper methods to make it easier to compare, loop through, and get the string representation of an event type.
- Use stronger typing on a couple of methods to ensure they only get the types of events they expect.
This will also make the final code a bit more readable and easier to alter in bugs like bug 1842970, as well as making it trivial to print actual event names rather than enum integers in our debug logs.
Updated•9 months ago
|
Severity: -- → N/A
Type: defect → task
Assignee | ||
Comment 1•9 months ago
|
||
Updated•9 months ago
|
Assignee: nobody → twisniewski
Status: NEW → ASSIGNED
Assignee | ||
Updated•9 months ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•