Closed Bug 1848043 Opened 1 year ago Closed 1 year ago

Headings on the sidebar are only styled to look like headings

Categories

(Firefox :: Shopping, defect, P3)

Product:
Firefox
Component:
Shopping
Platform:
Desktop
Unspecified
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
119 Branch
Project Flags:
Accessibility Severity s3
Tracking Flags:
Tracking Status
firefox119 --- fixed

People

(Reporter: ayeddi, Assigned: niklas, NeedInfo)

References

(Blocks 1 open bug,
URL
)

Details

(Keywords: access, Whiteboard: [fidefe-shopping] )

Attachments

(3 files)

Implicit_heading_main.png
(deleted), image/png
Details
Implicit_headings_Summary.png
(deleted), image/png
Details
Bug 1848043 - Fix headings in shopping sidebar. r=#shopping-reviewers,ayeddi
(deleted), text/x-phabricator-request
Details
Attached image Implicit_heading_main.png (deleted) —
  1. Main heading Review quality check is an implicit heading instead of being programmatically a heading too (instead of using either <H1> or <H2>)
  2. Other implicit headings are in the <summary> like How we determine review quality and Settings - those are expected to be programmatic headings of the next level after the main heading (i.e. if the main heading is <h2>, they should use <h3>)
Attached image Implicit_headings_Summary.png (deleted) —
Severity: -- → S4
Priority: -- → P3

The severity field for this bug is set to S4. However, the accessibility severity is higher, .
:jhirsch, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Flags: needinfo?(jhirsch)
Assignee: nobody → nbaumgardner
Status: NEW → ASSIGNED
Pushed by nbaumgardner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2d1127b72b5d Fix headings in shopping sidebar. r=shopping-reviewers,kpatenio
Pushed by sstanca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/846d86d89671 Fix lint failure. r=fix CLOSED TREE
Pushed by sstanca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/17d5a04c272d Fix second lint failure. r=fix CLOSED TREE

https://hg.mozilla.org/mozilla-central/rev/2d1127b72b5d
https://hg.mozilla.org/mozilla-central/rev/846d86d89671
https://hg.mozilla.org/mozilla-central/rev/17d5a04c272d

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox119: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: