Closed
Bug 1848167
Opened 1 year ago
Closed 1 year ago
`getPromptText` method on GeckoView prompt should be awaited
Categories
(Remote Protocol :: Agent, task, P1)
Remote Protocol
Agent
Tracking
(firefox118 fixed)
RESOLVED
FIXED
118 Branch
| Tracking | Status | |
|---|---|---|
| firefox118 | --- | fixed |
People
(Reporter: Sasha, Assigned: Sasha)
References
(Blocks 3 open bugs)
Details
(Whiteboard: [webdriver:m8])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
As we can see here, getPromptText is actually async and should be awaited in the modal class. It might not cause too many problems now with Marionette since here we return from async method, but it doesn't work here for the logs. It also breaks things for BiDi prompt events.
|
||
Comment 1•1 year ago
|
||
Very good find! This could actually be the reason for various test failures on Android related to alerts. I'm going and mark those as being blocked by this bug.
|
Assignee | |
Updated•1 year ago
|
Points: --- → 2
Priority: -- → P1
Whiteboard: [webdriver:m8]
|
|
Assignee | |
Updated•1 year ago
|
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•1 year ago
|
||
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/45b33d9f231a
[remote] Await `getPromptText` method from GeckoView prompt. r=webdriver-reviewers,whimboo
|
||
Comment 4•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox118:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•