Open Bug 1848765 Opened 1 year ago Updated 1 year ago

nsDisplayList::Sort should use nsTArray::StableSort

Categories

(Core :: Web Painting, enhancement)

enhancement

Tracking

()

People

(Reporter: smaug, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sp3])

Currently the method uses std::stable_sort on top of nsTArray
https://searchfox.org/mozilla-central/rev/ce049e593c7d062a039938cabccaab4c14b8ebfd/layout/painting/nsDisplayList.h#3197
That triggers ElementAt calls which do bound checks.
nsTArray::StableSort would avoid that.

https://bugzilla.mozilla.org/show_bug.cgi?id=1668200 has a similar fix for some animation code.

The ElementAt calls do show up in the profiles

Component: Layout → Web Painting
You need to log in before you can comment on or make changes to this bug.