Steps to reproduce:

1. Load some content
2. Use Accerciser to examine the implemented interfaces for elements on the page

Expected results: The hyperlink interface would be implemented.

Actual results: The hyperlink interface is not implemented.

Impact: Orca uses the hyperlink interface in its logic to piece together lines, specifically to connect a given child with its offset in the parent. In at least one case (so far), Orca is now failing to present content it used to present prior to the regression.

Regression range:
117.01a 07-30: good
117.01a 07-31: bad

I... have no idea what could have happened here.

[Tracking Requested - why for this release]: Some content is not accessible to Orca screen reader users.

After some digging, I'm fairly certain (but haven't verified) that this is a regression introduced by bug 1779578.

I think the problem is that we now call ProxyCreated before we attach to the parent, but IsLink (used to determine whether something should expose the HyperLink interface and called when the ATK object is created) depends on the presence of the parent!

Given the proximity to rc here, the simplest solution might be to back out bug 1779578 from 117.

Set release status flags based on info from the regressing bug 1779578

Sorry Joanie. I know there's been a bit of churn lately. On the flip side, I fixed most of the text bugs. :)

Urgh, sorry. Bugzilla submission screw-up on my part.

This is what we did before the fix for bug 1779578.
Failure to do this meant that RemoteAccessible::IsLink() returned false even for a child of a HyperText Accessible, which meant the ATK object was created without the HyperLink interface.

For some reason, I couldn't get Accerciser to show me the Firefox tree. There's probably some pebcak here, but I couldn't figure out what. :( Joanie, would you mind taking this try build for a spin and telling me whether it fixes the problem?

The try build does fix the problem. Thanks!

As for the text bugs: I had noticed that my debug output had a lot fewer (maybe zero?) instances of "FAIL: Bad results for text at offset" in it. Those lines come from Orca's sanity checking all Gecko text results and finding failures. Thus their absence suggests I might be able to remove (or at least turn off by default) those checks. Super cool and thanks!!

(In reply to James Teh [:Jamie] from comment #3)

Given the proximity to rc here, the simplest solution might be to back out bug 1779578 from 117.

Given where we are in the cycle and the note about risk mentioned in bug 1779578 comment 15, I'm inclined to agree about letting this bake for another cycle. I'll revert bug 1779578 from Beta for 117.0b9.

Fixed for Fx117 by backout.
https://hg.mozilla.org/releases/mozilla-beta/rev/4a0c1a095483

:jamie Fx118 is now the Beta, any timing concerns wtih landing this patch and requesting beta uplift?

I'm just waiting on review, which is a bit slow due to All Hands and the like, but I don't anticipate any problems.

https://hg.mozilla.org/mozilla-central/rev/39fc3941397d

The patch landed in nightly and beta is affected.
:Jamie, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox118 to wontfix.

For more information, please visit BugBot documentation.

Comment on attachment 9349344 [details]
Bug 1848991: Attach a RemoteAccessible to its parent before calling ProxyCreated.

Beta/Release Uplift Approval Request

• User impact if declined: Certain content isn't presented at all with the Orca screen reader on Linux.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Restores some previous behaviour before the regressing bug.
• String changes made/needed:
• Is Android affected?: No

Comment on attachment 9349344 [details]
Bug 1848991: Attach a RemoteAccessible to its parent before calling ProxyCreated.

Approved for 118.0b5, thanks.

https://hg.mozilla.org/releases/mozilla-beta/rev/9cf13283af3f