general.smoothScroll.pages = false does not work when scroll by mouse on scrollbar gutter in case of general.smoothScroll is enabled
Categories
(Core :: Layout: Scrolling and Overflow, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox-esr115 | --- | unaffected |
| firefox117 | --- | wontfix |
| firefox118 | --- | wontfix |
| firefox119 | --- | fixed |
People
(Reporter: alice0775, Assigned: rzvncj)
References
(Regression)
Details
(Keywords: nightly-community, regression)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Steps To Reproduce:
- set general.smoothScroll to true
- set general.smoothScroll.pages to false
- Open long page such as https://ftp.mozilla.org/pub/firefox/nightly/2023/01/2023-01-01-09-08-04-mozilla-central-l10n/
- Mouse down on scrollbar gutter and hold
Actual Results:
Scrolling appears smooth.
Expected results:
Page should scroll rough scrolling.
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2267e2cb83212ad23130e6bc5f12b88eb2068cd0&tochange=22f915e74381a95195bd1f1b9cdc43d70fdcdf58
FYI,
Bug 1847716 did not fix this case.
|
||
Comment 1•1 year ago
|
||
:rzvncj, since you are the author of the regressor, bug 1331390, could you take a look?
For more information, please visit BugBot documentation.
|
Assignee | |
Updated•1 year ago
|
|
|
Assignee | |
Comment 2•1 year ago
|
||
As per comment 7 in bug 1847716 this may be best left until bug 1840025 is fixed. Requesting info from :botond.
|
||
Comment 3•1 year ago
|
||
This is actually just a slight oversight in the fix for bug 1847716 -- the condition here should more precisely be StaticPrefs::general_smoothScroll() && StaticPrefs::general_smoothScroll_pages().
I would suggest making this tweak rather than waiting for bug 1840025 which is blocked on fixing a Mac-specific failure.
Razvan, would you like to make this tweak?
|
|
Assignee | |
Comment 4•1 year ago
|
||
(In reply to Botond Ballo [:botond] from comment #3)
This is actually just a slight oversight in the fix for bug 1847716 -- the condition here should more precisely be
StaticPrefs::general_smoothScroll() && StaticPrefs::general_smoothScroll_pages().I would suggest making this tweak rather than waiting for bug 1840025 which is blocked on fixing a Mac-specific failure.
Razvan, would you like to make this tweak?
Sure, no problem.
|
|
Assignee | |
Comment 5•1 year ago
|
||
|
||
Updated•1 year ago
|
|
||
Comment 7•1 year ago
|
||
| bugherder | ||
|
|
||
Comment 8•1 year ago
|
||
The patch landed in nightly and beta is affected.
:rzvncj, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox118towontfix.
For more information, please visit BugBot documentation.
|
|
Assignee | |
Comment 9•1 year ago
|
||
(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #8)
The patch landed in nightly and beta is affected.
:rzvncj, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox118towontfix.For more information, please visit BugBot documentation.
Probably not, but as usual it's :botond's call.
|
|
||
Comment 10•1 year ago
|
||
Yeah, I think this is enough of an edge case that we need not bother with an uplift.
Description
•