Open Bug 1850626 Opened 1 year ago Updated 1 year ago

1.6x slower than Chrome at setting .style.display

Categories

(Core :: CSS Parsing and Computation, task)

task

Tracking

()

ASSIGNED

People

(Reporter: mstange, Assigned: emilio)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sp3])

Attachments

(1 file, 1 obsolete file)

Attached file set-style-display-microbenchmark.html (deleted) —

On the attached testcase, I get the following scores:
Firefox: 340ms (Update: 285ms after bug 1851649)
Chrome: 210ms
Safari: 316ms

Matching Chrome's performance would improve Firefox's sp3 score by 0.2%. (This is equivalent to improving a single subtest by 4.1%.)

On Windows, the ratio is closer to 1.15x.
Firefox: 554ms https://share.firefox.dev/47VIDYg 12006 samples
Chrome: 482ms https://share.firefox.dev/3sx0dSf 10311 samples

On Windows 11 I get closer to 1.4x
Firefox nightly: 456
Chrome stable: 321

Flags: needinfo?(emilio)

(In reply to Markus Stange [:mstange] from comment #1)

Firefox: 554ms https://share.firefox.dev/47VIDYg 12006 samples

This was a profile of the reduced testcase.

Here's a profile from Speedometer 3: https://share.firefox.dev/3P2r0xm

It looks quite a bit different.

This avoids uselessly rewinding the parser for single-keyword display
values, and generally makes the code easier to follow.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Flags: needinfo?(emilio)
Depends on: 1851649

Comment on attachment 9351539 [details]
Bug 1850626 - Simplify and speed-up display parsing. r=#style,#layout,mstange

Revision D187431 was moved to bug 1851649. Setting attachment 9351539 [details] to obsolete.

Attachment #9351539 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: