Open Bug 1851378 Opened 1 year ago Updated 1 year ago

macOS Back Swipe Behaviour Broken By Certain Extensions Since 116

Categories

(Core :: Panning and Zooming, defect)

Firefox 117
defect

Tracking

()

UNCONFIRMED

People

(Reporter: paul, Unassigned)

References

(Regression)

Details

(Keywords: regression)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

Install HoverZoom extension - broken on any website
Install Something Awful Last Read Redux - broken on forums.somethingawful.com

Actual results:

With these add-ons installed, the macOS forward and backwards swipe gestures are broken.
Vertical scroll on a page, and you are unable to use the gestures for forward/back for around 3 seconds after you've stopped scrolling.
This is reproducible 100% of the time.

I've tested on 117 and Nightly and the issue persists.

The reason I think this is a regression in Firefox vs the fault of the add-ons is that Something Awful Last Read Redux has not been updated since 10 Jul 2022, worked flawlessly before 116, and is now affected by this bug.

Disabling both extensions restores correct behaviour.

Expected results:

macOS swipe forward/back should work correctly immediately after vertical scrolling even with these add-ons enabled.

The Bugbug bot thinks this bug should belong to the 'Core::Panning and Zooming' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Panning and Zooming
Product: Firefox → Core

Thanks for the report.

Could you please try using https://mozilla.github.io/mozregression/ to determine the Firefox change that broke this?

Flags: needinfo?(paul)

What a cool tool!

Turns out it's quite a bit older than I thought - https://phabricator.services.mozilla.com/D172025

Last good: 275a0c35
Final bad: cb782a3a

Flags: needinfo?(paul)

Seems to be fixed by setting the
dom.event.wheel-event-groups.enabled
mentioned in that commit to false

so it would seem it is indeed something to do with that setting

(In reply to paul from comment #4)

Seems to be fixed by setting the
dom.event.wheel-event-groups.enabled
mentioned in that commit to false

so it would seem it is indeed something to do with that setting

dom.event.wheel-event-groups.enabled has been set to true by default for a while. Do you have the default value set? Is the previous behavior restored if the value of dom.event.wheel-event-groups.enabled is changed?

Flags: needinfo?(paul)

dom.event.wheel-event-groups.enabled was set to true for me. I've never touched that setting before just now. This bug happens when it's set to true. Overriding it to be false stops the bug from happening.

So it's something with that setting being true which breaks these gestures.

Flags: needinfo?(paul)

(In reply to paul from comment #6)

dom.event.wheel-event-groups.enabled was set to true for me. I've never touched that setting before just now. This bug happens when it's set to true. Overriding it to be false stops the bug from happening.

So it's something with that setting being true which breaks these gestures.

Under normal circumstances it wouldn't break swipe to navigate gestures, but there is probably something in the addon that is interacting poorly with the changes made to fix bug 1168182. Hoverzoom does seem to have support for Chrome and the changes made to fix bug 1168182 make our wheel events behave more like Chrome, but perhaps there is some Firefox specific behavior in hoverzoom used for wheel events.

Keywords: regression
Regressed by: 1168182
You need to log in before you can comment on or make changes to this bug.