Closed Bug 18584 Opened 25 years ago Closed 25 years ago

[FEATURE] Include drafts warning when closing compose window

Categories

(MailNews Core :: Composition, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: phil, Assigned: bugzilla)

References

Details

(Whiteboard: [PDT-])

Attachments

(1 file)

In 4.x, if you close a compose window that you have typed into, you get a warning asking whether you want to save the message as a draft. Right now in mozilla, the window closes and your message is lost with no warning at all. Note that if you haven't typed in the body, there shouldn't be a warning.
Blocks: 10791
QA Contact: lchiang → laurel
Status: NEW → ASSIGNED
Target Milestone: M14
M15
Target Milestone: M14 → M15
Note: The "warn before closing window with content" behavior is hooked up in the Composer component.
add myself to cc list. This is a data loss bug.
Keywords: beta2
I will try to implement this feature for today by 4pm.
Keywords: beta2beta1
Target Milestone: M15 → M14
I have a fix...
Whiteboard: Fix in hand
Attached patch proposed implementation (deleted) — Splinter Review
The fix was more complex that expected. The fix should be pretty safe, the only problem that could appends is either we ask to save the window when we should not or we don't ask when we should. In the worst scenario, the user won't be able to close the window or quit the app but I sure at 99.99%. know problem: 1) during a reply/reply all/forward, we ask to save the window event if the user has not touch the content! 2) if you just type into one of the addressing widget or subject edit field and close the window without pressing <enter> or clicking somewhere else in the window, we don't ask to save.
Putting on PDT- radar for beta1. Will relnote.
Keywords: relnote
Whiteboard: Fix in hand → [PDT-]Fix in hand
oops, I forget to use entity or property for string use by the save dialog! Anyway, this fix imply UI change and therefore it's too late for B1 as UI is already frozen.
Thanks for trying this. We decided to go minus because you said it was a little complex. Sorry, I should have caught this a week ago then we would have had it in. Thanks much for trying. Adding beta2 keyword. Please check into the trunk.
Keywords: beta2
Fixed and checked in (NOT IN BETA 1). I have also fixed problem #1 I mentioned earlier
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Whiteboard: [PDT-]Fix in hand → [PDT-]
Feature is generally implemented. Will log any problems with draft warning as separate issues. Marking this feature bug verified (plain text and html compose, new message, reply and reply all) with: 2000-03-30-09m15 commercial build linux rh6.0 2000-03-30-09m15 commercial build NT 4.0 2000-03-30-10m15 commercial build mac OS 9.0
Status: RESOLVED → VERIFIED
Keywords: nsbeta2
Product: MailNews → Core
Product: Core → MailNews Core
Keywords: relnote
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: