Closed
Bug 18676
Opened 25 years ago
Closed 14 years ago
Double quoted addresses look different in news and mail
Categories
(MailNews Core :: Composition, defect, P3)
MailNews Core
Composition
Tracking
(Not tracked)
RESOLVED
WORKSFORME
Future
People
(Reporter: phil, Unassigned)
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Rich, your recent news post had the from header:
From: Rich Pizzarro (News Post) <rhp@netscape.com>
which isn't legal by RFC 822 rules. It should be:
From: "Rich Pizzarro (News Post)" <rhp@netscape.com>
I know we have code for this lying around, but maybe it's not getting called?
Comment 1•25 years ago
|
||
adding seth to this because I think he recently was working with the MAIL FROM
part of this in SMTP
Updated•25 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M13
Comment 2•25 years ago
|
||
Any idea what the old call was to make sure these addresses are valid?
- rhp
Reporter | ||
Comment 3•25 years ago
|
||
See msg_make_full_address() in ns\lib\libmsg\addrutil.cpp
Comment 4•25 years ago
|
||
I have a fix for that in my tree. Fell free to reassign this bug to me.
Reporter | ||
Updated•25 years ago
|
Assignee: rhp → ducarroz
Status: ASSIGNED → NEW
Updated•25 years ago
|
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Target Milestone: M13 → M12
Comment 5•25 years ago
|
||
Fixed and checed in. Review by jefft
Updated•25 years ago
|
Status: RESOLVED → REOPENED
QA Contact: lchiang → nbaca
Updated•25 years ago
|
Resolution: FIXED → ---
Comment 6•25 years ago
|
||
Build 1999121308M12: NT4, Linux/Rehat 6.0, Mac 8.5.1
Reopen
Problem: 5.0 does not display the quotes in the From: field when special
characters are present in the `Your Name` field in the Identities panel.
Steps to reproduce:
1. In the Identity panel change the `Your Name` field to include special
characters such as parenthesis (`Ninoschka Baca (News Post)`)
2. Create and send a news message using 4.7
3. View the message in 4.7
4. View the message in 5.0
5. Create and send a news message using 5.0
6. View the message in 4.7
7. View the message in 5.0
Actual Reqults: Notice that both messages do not display the quotes in 5.0 but
do display them in 4.7.
Expected Results: 5.0 should display the quotes when special characters are
present - "Ninoschka Baca (News Post)" <nbaca@netscape.com>
Updated•25 years ago
|
Status: REOPENED → ASSIGNED
Comment 7•25 years ago
|
||
Right, when we display a message, we unquoted the recipients email adresses,
just nicer. I don't think so is a problem. Rich, what do you thing?
Updated•25 years ago
|
Target Milestone: M12 → M13
Comment 8•25 years ago
|
||
The only issue I see with unquoting recipients is that if somebody while writing
an email to one of those recipient write manually exactly what he/she see, it
will not work!
Reporter | ||
Comment 9•25 years ago
|
||
JF, in that case, we're supposed to re-apply all the required quoting, which is
what the old products do.
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Comment 10•25 years ago
|
||
I have a fix for that (see attachment) but now that mscott has landed the new message display which doesn't use
anymore the XUL emitter, the patch as no sence. Fortunally, the new message display show the email address as it
has been received therefore it's already quoted when needed. Therefore I mark this bug as fixed.
Comment 11•25 years ago
|
||
Comment 12•25 years ago
|
||
Build 2000012009M13: NT4
Haven't checked Mac or Linux yet.
Reopening.
1. News Identity using special characters (i.e. parenthesis)
a. Quotes appear in the "From:" field when reading news messages, which is good:
"qatest32 (news post)" <qatest32@netscape.com>.
b. If the same news message is sent to an email account, when the message is
displayed in the mail account then the from field strips the area in parenthesis
and states: qatest32<qatest32@netscape.com>
- 4.7's behavior is different. It displays: qatest32@netscape.com (qatest32). -
How should this work? Why does it strip the "(news post)" portion? I would have
expected: "qatest32 (news post)" <qatest32@netscape.com>.
c. Select "Reply" and the area in parenthesis is removed in the "From:" field,
This doesn't seem right:
qatest32<qatest32@netscape.com>
2. Mail Identity using special characters (i.e. parenthesis)
If I place special characters in the "Your Name" field for my Mail identity then
I wouldn't expect anything to be stripped when sending or viewing the message
but the current behavior strips it anytime it is viewed in a mail message. Would
this be a seperate issue/bug?
Status: RESOLVED → REOPENED
Updated•25 years ago
|
Resolution: FIXED → ---
Comment 13•25 years ago
|
||
But can send the message despite this problem? if yes, I will move it to M14.
Comment 14•25 years ago
|
||
Build 2000012008M13: Linux and Mac behavie the same way.
Yes, the message gets sent without a problem.
Reporter | ||
Comment 17•25 years ago
|
||
Since we do the double quoting now, I think that's enough for B1. The remaining
part of this bug (quoted address looking different in mail than in news) can
wait for post B1.
Summary: RFC 822 special characters must be quoted → Double quoted addresses look different in news and mail
Target Milestone: M14 → M16
Comment 18•25 years ago
|
||
Not beta2 stopper. Marking M18.
Comment 20•24 years ago
|
||
Moving to future milestone. If this causes a serious end user or interop
problem, feel free to add that information to the bug so we can reconsider.
Target Milestone: M18 → Future
Comment 21•24 years ago
|
||
Adding mail3 keyword.
Comment 25•22 years ago
|
||
taking all of varada's bugs.
Assignee: varada → sspitzer
Status: ASSIGNED → NEW
Updated•20 years ago
|
Product: MailNews → Core
Comment 26•17 years ago
|
||
sorry for the spam. making bugzilla reflect reality as I'm not working on these bugs. filter on FOOBARCHEESE to remove these in bulk.
Assignee: sspitzer → nobody
Assignee | ||
Updated•16 years ago
|
Product: Core → MailNews Core
Comment 28•14 years ago
|
||
As near as I can tell from the STR, this is WFM.
Status: NEW → RESOLVED
Closed: 25 years ago → 14 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•