Closed Bug 188253 Opened 22 years ago Closed 15 years ago

Save Page should supply web page descriptor / cache key when calling saveURI

Categories

(SeaMonkey :: Download & File Handling, defect)

Product:
SeaMonkey
Component:
Download & File Handling
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.0

People

(Reporter: adamlock, Assigned: iannbugzilla)

References

Details

(Keywords: fixed-seamonkey2.0)

Attachments

(1 file, 2 obsolete files)

port 84106 to SM passing cacheKey patch v0.1b [Checkin: Comment 10]
(deleted), patch
neil
: review+
neil
: superreview+
kairo
: approval-seamonkey2.0+
Details | Diff | Splinter Review
nsIWebBrowserPersist::saveURI has a new cache key argument. The calls to saveURI in the download progress / content area utils should make use of it.
*** Bug 196871 has been marked as a duplicate of this bug. ***
Product: Browser → Seamonkey
Assignee: bross2 → download-manager
QA Contact: chrispetersen
For Firefox, this was fixed in bug 84106. The fix should probably be ported to SeaMonkey, but for a more comprehensive solution see bug 484616.
Assignee: download → nobody
Blocks: 484616, FF2SM
Depends on: 84106
Flags: blocking-seamonkey2?
QA Contact: download
Attached patch port 84106 to SM patch v0.1 (obsolete) (deleted) — — Splinter Review
This patch: * Ports the contentAreaUtils.js part of bug 84106 to SM.
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #399585 - Flags: superreview?(neil)
Attachment #399585 - Flags: review?(neil)
OS: Windows XP → All
Hardware: x86 → All
Comment on attachment 399585 [details] [diff] [review] port 84106 to SM patch v0.1 >+ cacheKey = >+ ifreq.getInterface(Components.interfaces.nsIWebNavigation) >+ .QueryInterface(Components.interfaces.nsIWebPageDescriptor); .currentDescriptor surely? >+ if (aCacheKey == undefined) >+ aCacheKey = null; Unnecessary.
(In reply to comment #4) >(From update of attachment 399585 [details] [diff] [review]) >>+ cacheKey = >>+ ifreq.getInterface(Components.interfaces.nsIWebNavigation) >>+ .QueryInterface(Components.interfaces.nsIWebPageDescriptor); >.currentDescriptor surely? Bah, so as per bug 84106 currentDescriptor doesn't work in 1.9.1, so we have two options: 1. Just getInterface(Components.interfaces.nsIWebNavigation), because saveURI will work things out, assuming the page doesn't change while we're saving. 2. Actually get the necko cache key, using cacheKey = ifreq.getInterface(Components.interfaces.nsIWebNavigation) .QueryInterface(Components.interfaces.nsIWebPageDescriptor) .currentDescriptor .QueryInterface(Components.interfaces.nsISHEntry).cacheKey;
Blocks: 515501
Attachment #399585 - Flags: superreview?(neil)
Attachment #399585 - Flags: review?(neil)
Changes since v0.1: * Removed unnecessary undefined check. Switching to using .currentDescriptor has been spun off into bug 515501 for once SM has switched to using current trunk (1.9.3.x)
Attachment #399585 - Attachment is obsolete: true
Attachment #399617 - Flags: superreview?(neil)
Attachment #399617 - Flags: review?(neil)
Attachment #399617 - Flags: superreview?(neil)
Attachment #399617 - Flags: review?(neil)
Changes since v0.1a: * Passes cacheKey through to internalSave to use with saveURI. This can be optimised to currentDescriptor in bug 515501 once SM has switched to trunk.
Attachment #399617 - Attachment is obsolete: true
Attachment #399622 - Flags: superreview?(neil)
Attachment #399622 - Flags: review?(neil)
Comment on attachment 399622 [details] [diff] [review] port 84106 to SM passing cacheKey patch v0.1b [Checkin: Comment 10] I finally figured out how to test this (by saving a page from online banking).
Attachment #399622 - Flags: superreview?(neil)
Attachment #399622 - Flags: superreview+
Attachment #399622 - Flags: review?(neil)
Attachment #399622 - Flags: review+
Comment on attachment 399622 [details] [diff] [review] port 84106 to SM passing cacheKey patch v0.1b [Checkin: Comment 10] Minor fix but a good one, requesting a=
Attachment #399622 - Flags: approval-seamonkey2.0?
Attachment #399622 - Flags: approval-seamonkey2.0? → approval-seamonkey2.0+
Attachment #399622 - Attachment description: port 84106 to SM passing cacheKey patch v0.1b → port 84106 to SM passing cacheKey patch v0.1b [Checkin: Comment 10]
Comment on attachment 399622 [details] [diff] [review] port 84106 to SM passing cacheKey patch v0.1b [Checkin: Comment 10] http://hg.mozilla.org/comm-central/rev/c701c317b3fd
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: fixed-seamonkey2.0
Resolution: --- → FIXED
Flags: blocking-seamonkey2.0?
Target Milestone: --- → seamonkey2.0
Depends on: 516189
No longer blocks: FF2SM
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: