Closed Bug 189496 Opened 22 years ago Closed 22 years ago

Capitalize accesskeys in cache preferences

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

Product:
Core
Component:
DOM: UI Events & Focus Handling
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: piers, Assigned: piers)

References

Details

(Keywords: access)

Attachments

(2 files, 2 obsolete files)

Capitalize accesskeys
(deleted), patch
dean_tessman
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review
coolest version ever
(deleted), patch
dean_tessman
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review
Capitalize accesskeys in cache preferences: Me_m_ory Cache Clear Memory Ca_c_he
Attached patch Capitalize accesskeys (deleted) — — Splinter Review
out of curiosity, would this capitalize the access key if the access key were in the middle of a word? that doesn't seem right, since they're usually underlined. unless i'm misunderstanding what you're doing here... cc'ing aaronl, the accessibility module owner.
Keywords: access
Attachment #111850 - Flags: superreview?(bzbarsky)
Attachment #111850 - Flags: review?(dean_tessman)
I don't quite understand your question, but what i'm doing is ensuring that the underlined letter is the initial letter instead of some later lowercase occurance of the same letter.
now it finally dawned on me. thanks a lot! :)
Attachment #111850 - Flags: superreview?(bzbarsky) → superreview+
Attachment #111850 - Flags: review?(dean_tessman) → review+
Checked in. Marking fixed.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
the Cache panel has changed since this was checked in, i believe, overriding Piers' changes. i'm going to reopen this in case Piers wishes to check in something for the latest version of this panel. (but, feel free to re-resolve this and open a new bug, if you want.)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Damn irritating when people overwrite your changes... thanks for the heads up sairuh.
Blocks: 193068
Attached patch this should do the trick (obsolete) (deleted) — — Splinter Review
The attached patch capitalizes (again) the accesskeys. It also fixes the alignment of a couple of lines.
Attached patch a better one (obsolete) (deleted) — — Splinter Review
Don't capitalize the accesskey if in the middle of a word.
Attachment #120838 - Attachment is obsolete: true
Attached patch coolest version ever (deleted) — — Splinter Review
Thanks for the clear instructions, this patch should be the right one.
Attachment #120839 - Attachment is obsolete: true
Comment on attachment 120849 [details] [diff] [review] coolest version ever Looks good to me, over to dean for review :)
Attachment #120849 - Flags: review?(dean_tessman)
Comment on attachment 120849 [details] [diff] [review] coolest version ever Sure, looks good.
Attachment #120849 - Flags: review?(dean_tessman) → review+
Comment on attachment 120849 [details] [diff] [review] coolest version ever Asking for sr=. Piers: please check this in, when it gets the sr=.
Attachment #120849 - Flags: superreview?(bzbarsky)
Attachment #120849 - Flags: superreview?(bzbarsky) → superreview+
Checking in mozilla/xpfe/components/prefwindow/resources/locale/en-US/pref-cache.dtd; /cvsroot/mozilla/xpfe/components/prefwindow/resources/locale/en-US/pref-cache.dtd,v <-- pref-cache.dtd new revision: 1.21; previous revision: 1.20 done
Status: REOPENED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED
hm, i think the change in bug 188956 might've clobbered the checkin intended here. using today's build (2003.04.23), here are the current access keys for the Cache pref panel: _C_ache textfield (capital C) C_l_ear Cache button (lowercase l) C_h_oose Folder button (lowercase h) should this bug be reopened?
sairuh, nah, that's the expected behaviour - like it used to be Ca_c_he and is now _C_ache.
thanks for the clarification, piers! okidikes, verifying as fixed.
Status: RESOLVED → VERIFIED
Component: Keyboard: Navigation → User events and focus handling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: