Closed
Bug 189563
Opened 22 years ago
Closed 22 years ago
use of uninitialized value found by valgrind
Categories
(Other Applications Graveyard :: Venkman JS Debugger, defect)
Other Applications Graveyard
Venkman JS Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: roc, Assigned: rginda)
References
Details
(Keywords: valgrind)
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Valgrind was complaining about the use of an uninitialized value in a
conditional in jsinterp.c, and sure enough, _callHook in jsd_step.c appears to
not initialize hookresult. Patch follows.
|
Reporter | |
Comment 1•22 years ago
|
||
I'm not completely sure what hookresult is supposed to mean, but this looks
right, and certainly can only improve the situation.
|
||
Comment 2•22 years ago
|
||
->JSD
Assignee: brendan → rginda
Component: JavaScript Engine → JavaScript Debugger
QA Contact: pschwartau → caillon
|
|
||
Comment 3•22 years ago
|
||
Comment on attachment 111893 [details] [diff] [review]
probable fix
Rob, wanna review this?
Attachment #111893 -
Flags: review?(rginda)
|
Assignee | |
Comment 4•22 years ago
|
||
hookresult controls whether or not the call hook is called again on the way out
of the function in question. I'd rather return JS_TRUE, just to be safe.
I'll check this in when the tree opens.
Status: NEW → ASSIGNED
|
||
Comment 5•22 years ago
|
||
According to brad TBox, the warning is gone.
|
|
||
Updated•22 years ago
|
Attachment #111893 -
Flags: review?(rginda)
|
||
Updated•20 years ago
|
Product: Core → Other Applications
|
||
Updated•6 years ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•