Closed
Bug 189740
Opened 22 years ago
Closed 22 years ago
[ps] Adding CID support Check Code to postscript should be closed when TrueType printing is disabled
Categories
(Core :: Printing: Output, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: Louie.Zhao, Assigned: Louie.Zhao)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
Louie.Zhao
:
review+
blizzard
:
superreview+
|
Details | Diff | Splinter Review |
Now the "CID support Check Code" will be added to postscript if freetype is
enabled. The most Linux users (their systems have freetype) who don't enable
TrueType printing will still have these checking code in postscript when printing.
bstell: will the CID checking code stop the printing process if the printer
doesn't support CID? If answer is yes, I think the patch should be applied; if
answer is no, the current code is ok.
|
Assignee | |
Comment 1•22 years ago
|
||
Stop outputing CID check code to postscript when TrueType printing is disabled.
|
|
Assignee | |
Updated•22 years ago
|
Attachment #112019 -
Flags: review?(bstell)
Comment on attachment 112019 [details] [diff] [review]
working patch
Louie, we should also determine whether we have embedded the CID fonts
|
|
Assignee | |
Updated•22 years ago
|
Attachment #112019 -
Flags: review?(bstell)
|
|
Assignee | |
Updated•22 years ago
|
Attachment #112023 -
Flags: review?(bstell)
|
||
Comment 4•22 years ago
|
||
Looks great!
Minor nit: could we change mTTPEnable to mFTPEnable?
+ if (mTTPEnable) {
+ rv = pref->GetBoolPref("font.FreeType2.printing", &mTTPEnable);
I had noticed it embedded fonts even if they were not used so I was happy to see
this:
- FT2SubsetToType8(face, mSubset.get(), mSubset.Length(), wmode, aFile);
+ if (mSubset.Length() > 0)
+ FT2SubsetToType8(face, mSubset.get(), mSubset.Length(), wmode, aFile);
|
|
||
Updated•22 years ago
|
Attachment #112023 -
Flags: review?(bstell) → review+
|
|
Assignee | |
Comment 5•22 years ago
|
||
Attachment #112023 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•22 years ago
|
||
Comment on attachment 112120 [details] [diff] [review]
patch following bstell's comments
bring bstell's "r" here
Attachment #112120 -
Flags: review+
|
||
Comment 7•22 years ago
|
||
Comment on attachment 112120 [details] [diff] [review]
patch following bstell's comments
sr=blizzard
Attachment #112120 -
Flags: superreview+
|
||
Updated•22 years ago
|
Summary: Adding CID support Check Code to postscript should be closed when TrueType printing is disabled → [ps] Adding CID support Check Code to postscript should be closed when TrueType printing is disabled
checked in by louie.zhao@sun.com on 01/21/2003
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•