I'm getting a crash when viewing some pages in the new code that was introduced last night. The crashing code is here: + // Even if the integer could not be parsed, it might just be "*" + tmp.CompressWhitespace(PR_TRUE, PR_TRUE); + if (tmp.Last() == '*' && tmp.Length() == 1) { tmp in this case is empty, which apparently will crash. I'm waiting for a debug build to finish building so I can patch this. It's probably as simple as reversing the two calls. (Someone tells me that calling .Last() on an empty string will crash, which just seems crazy to me. Maybe it isn't, it's just surprising.) I need to get the URL that crashes this from mail.

Reverse the check.

*** Bug 190060 has been marked as a duplicate of this bug. ***

Comment on attachment 112278 [details] [diff] [review] patch sr=scc

*** Bug 190148 has been marked as a duplicate of this bug. ***

Is this what's causing me to crash whenever I try to load http://www.fuckedcompany.com/ today? I've had four crashes just today (two on that site) after installing the 2003012208 build. I don't remember having any for weeks before that...

Comment on attachment 112278 [details] [diff] [review] patch a=roc+moz

Checked in.

*** Bug 190246 has been marked as a duplicate of this bug. ***

*** Bug 190296 has been marked as a duplicate of this bug. ***

*** Bug 191132 has been marked as a duplicate of this bug. ***

*** Bug 191226 has been marked as a duplicate of this bug. ***

*** Bug 191509 has been marked as a duplicate of this bug. ***

If Bug 191509 really is a duplicate of this, and this has been fixed, then the patch has not been included in the latest build of Fizzilla-cfm. The latest MacOSX Mozilla downloaded today (3 Feb) "Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.3b) Gecko/20030122" still crashes when going to the muffaletta link http://www.foodtv.com/terms/tt-r2/0,4474,4111,00.html

Joseph: your build reports that it is using Gecko/20030122, which means 22nd of January 2003. This bug was reportet on the very same day, so it is still possible that this is a dupe. Sorry, I don't know anything about the Mac versions, but isn't there a build using a later version of the Mozilla renderer, which can be testet?

"isn't there a build using a later version of the Mozilla renderer, which can be testet?" No, that was my point, the patch is not in the latest Mac build. The latest Fizilla <http://ftp.mozilla.org/pub/mozilla/nightly/latest/mozilla-macosX-cfm.smi.bin> is the 22 Jan build. I don't have the software required to pull the source and build it myself, so I don't know if doing so would include the patch. It wouldn't matter anyway if 90% of users just download the broken binary.