Closed Bug 191048 Opened 22 years ago Closed 22 years ago

Need to install .js files in Mozilla's not GRE's component dir

Categories

(SeaMonkey :: Installer, defect)

x86
Windows 2000
defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ssu0262, Assigned: ssu0262)

Details

Attachments

(1 file, 1 obsolete file)

The following .js files need to be moved from the GRE's components dir to Mozilla's components dir: bin\components\nsProgressDialog.js bin\components\nsHelperAppDlg.js bin\components\nsDownloadProgressListener.js This needs to be done after bug 190560 is fixed. I'll do a manual verification that moving these .js files does not regress bug 190465.
Attached patch patch v1.0 (ns tree) (obsolete) (deleted) — Splinter Review
Attached patch patch v1.0 (moz tree) (deleted) — Splinter Review
Attachment #113116 - Flags: superreview?(dveditz)
Attachment #113116 - Flags: review?(sspitzer)
Attachment #113115 - Flags: superreview?(dveditz)
Attachment #113115 - Flags: review?(sspitzer)
Comment on attachment 113115 [details] [diff] [review] patch v1.0 (ns tree) r=sspitzer
Attachment #113115 - Flags: review?(sspitzer) → review+
Comment on attachment 113116 [details] [diff] [review] patch v1.0 (moz tree) r=sspitzer
Attachment #113116 - Flags: review?(sspitzer) → review+
doug, chak, do you guys think this is a topembed bug since the download manager still works and that bug 190560 is fixed?
Status: NEW → ASSIGNED
what .js files are being installed into the GRE?
bin\components\nsProgressDialog.js bin\components\nsHelperAppDlg.js bin\components\nsDownloadProgressListener.js
those files should exist in the application component directory.
Why the added chrome registration line? The existing registration of the parent "content/communicator/" should cover it.
I did not realize that. Just noticed that it was missing when comparing against the pregenerated installed-chrome.txt file. I'll remove it before checkin it in.
Comment on attachment 113115 [details] [diff] [review] patch v1.0 (ns tree) This isn't needed
Attachment #113115 - Attachment is obsolete: true
Attachment #113115 - Flags: superreview?(dveditz) → superreview-
Comment on attachment 113116 [details] [diff] [review] patch v1.0 (moz tree) sr=dveditz on the package list changes, - on the extra chrome registration
Attachment #113116 - Flags: superreview?(dveditz) → superreview+
just the moz patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
verified in mozilla 2003031108
Status: RESOLVED → VERIFIED
QA Contact: bugzilla → gbush
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: