As discussed at the 9/20/02 and 1/24/03 API review meetings these APIs are ready to be frozen. Hopefully targetting 1.3 final since this is only a status comment change. See here for the details: http://www.mozilla.org/projects/embedding/apiReviewNotes.html#nsIWebBrowserFocus http://www.mozilla.org/projects/embedding/apiReviewNotes.html#nsIWebBrowserChromeFocus Please follow the guidelines outlined in the "How to mark an interface as FROZEN" at http://www.mozilla.org/projects/embedding/HowToFreeze.html Nominating topembed from the get-go.

->bryner, should be easy since you have a tree

Discussed in edt bug triage. Plussing.

Brian, do you think we can make these changes (just comments, rights?) in time for 1.3 final? Taking the liberty of updating the target milestone for you, and nominating as blocker for 1.3 ...

cleaned up comments and style, and marked as frozen. I tried to explain some of the more quirky aspects of activate and deactivate as well.

Comment on attachment 114648 [details] [diff] [review] patch Chris, can you take a look at the comments I added for activate and deactivate and make sure they make sense?

Comment on attachment 114648 [details] [diff] [review] patch r=saari

Comment on attachment 114648 [details] [diff] [review] patch sr=alecf

Comment on attachment 114648 [details] [diff] [review] patch Can we get this interface in for 1.3? Comment changes only.

Um.. how come there was no announcement on n.p.m.embedding or the api-announce list about the proposed freeze of this interface?

There was, see the message below: Return-Path: <jjmata@netscape.com> Received: from netscape.com ([10.169.105.86]) by judge.mcom.com (Netscape Messaging Server 4.15) with ESMTP id H95DU902.RFI; Wed, 22 Jan 2003 19:32:33 -0800 Message-ID: <3E2F6248.5090701@netscape.com> Date: Wed, 22 Jan 2003 19:32:24 -0800 From: jjmata@netscape.com (Juan Jose Mata) User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.0.2) Gecko/20021120 Netscape/7.01 X-Accept-Language: en-us, en MIME-Version: 1.0 Newsgroups: netscape.public.mozilla.embedding,netscape.public.mozilla.porkjockeys To: Chris Saari <saari@netscape.com>, Alec Flett <alecf@netscape.com>, Radha Kulkarni <radha@netscape.com>, John Keiser <jkeiser@netscape.com>, Brian Ryner <bryner@netscape.com> CC: Daniel Matejka <danm@netscape.com>, Judson Valeski <valeski@netscape.com>, mozilla-api-announce@mozilla.org Subject: API review agenda (1/24/03) - Embedding Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Follow up on past Embedding API review meetings. We'll cover the two APIs listed below on Friday the 24th starting at 1:00pm, Pacific time. If you're in Mountain View, we'll be in the Ironsides (B21-1) conference room. Dial in info: Local: 703-265-4200 Toll free: (866) 477-9620 Scheduled Meeting ID: 1212 --disclaimer-- The list is a simple enumeration of the APIs that we know are being used by some of our clients. It does not intend to imply that freezing of that API is the motivation, but rather that we need to understand why its use was necessary and whether other interfaces exist now/should be created to handle the needs, where necessary. --disclaimer-- If you're on the 'to' list of this mail, your attendance is requested (though anyone is always welcome). Handouts will not be provided, so if you're not familiar w/ the interfaces being discussed, please bring your own printout via printing the idl links below. The living notes document for the API Review is available at http://www.mozilla.org/projects/embedding/apiReviewNotes.html Agenda: nsIWebBrowserChromeFocus (Chris Saari) - http://lxr.mozilla.org/seamonkey/source/embedding/browser/webBrowser/nsIWebBrowserChromeFocus.idl nsIWebBrowserFocus (Chris Saari) - http://lxr.mozilla.org/seamonkey/source/embedding/browser/webBrowser/nsIWebBrowserFocus.idl

Yes, but note the disclaimer in that announcement and the fact that the _results_ of these meetings are not publicised. So what happens if you missed the meeting? I don't have any strong views on this particular interface, but could we please carry through on our promise of announcing "this interface is about to freeze" when it's about to freeze?

Sure. The API review notes were updated as advertised, so the information was indeed available. The only thing missing was a "go take a look at the review notes" reminder or a quick recap on the meeting outcome on the same public aliases. I'll try to make sure these happen going forward as well.

Comment on attachment 114648 [details] [diff] [review] patch a=asa (on behalf of drivers) for checkin to 1.3

checked in.

jj, my apologies for missing the updating of the API review notes.... and thank you in advance for those reminders!

Verified