With a Linux debug cvs trunk build form this morning plus the patch from bug 192049 and using a proxy server I get this warning when loading <http://www.macromedia.com> WARNING: NS_ENSURE_TRUE(mPump) failed, file nsInputStreamChannel.cpp, line 121 That's with shockwave installed. I have no idea how important this is.

what version of the source are you using? my line numbers (trunk CVS build) do not line up to yours.

CVS says there's no difference between my copy and the trunk. Odd. In any case it's here. 118 NS_IMETHODIMP 119 nsInputStreamChannel::Cancel(nsresult status) 120 { 121 NS_ENSURE_TRUE(mPump, NS_ERROR_NOT_INITIALIZED); 122 return mPump->Cancel(status); 123 } 124

ho, hum... er... that be because i was looking at nsInputStreamPump.cpp instead of nsInputStreamChannel.cpp :P

nsJSChannel::AsyncOpen is doing some wacky stuff, like calling Cancel on the input stream channel when it hasn't called AsyncOpen on it yet. that's against the rules of the API. in this case, i'm not sure that it has any negative side effects. -> future (unless this proves to cause trouble)

Shouldn't that Cancel() call just be removed? I can't think of any reasons we would be calling that AsyncOpen() with an already-open channel... In any case, I may look at this when I get back from vacation.

-> whitebox qa

-> default owner

Checkin for bug 351633 fixed this.