Closed
Bug 193965
Opened 22 years ago
Closed 22 years ago
On product change, user can accidentally opt-out of required group restriction
Categories
(Bugzilla :: Creating/Changing Bugs, defect, P2)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: bugreport, Assigned: bugreport)
References
Details
(Whiteboard: [fixed in 2.17.4])
Attachments
(1 file)
|
(deleted),
patch
|
justdave
:
review+
bbaetz
:
review+
|
Details | Diff | Splinter Review |
If a bug is in a product where a group restriction is optional AND the bug is
moved to a product where that same group restriction is mandatatory AND the user
choses "no" to "should the bug be placed in the new product's group"
THEN
The bug is removed from the previously-optional-now-mandatory group. This will
be detected by sanitycheck and will be corrected the first time the bug is edited.
(This was seen on a 2.17.3 variant.... still needs to be confirmed on TIP)
|
Assignee | |
Comment 1•22 years ago
|
||
Yeah, this exists on the tip as well.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P2
Target Milestone: --- → Bugzilla 2.18
|
|
Assignee | |
Comment 2•22 years ago
|
||
OK, fix seems to work. We will no longer remove old default groups if they are
mandatory for the new product.
|
|
Assignee | |
Updated•22 years ago
|
Attachment #114858 -
Flags: review?(justdave)
|
||
Comment 3•22 years ago
|
||
Comment on attachment 114858 [details] [diff] [review]
The fix
Looks pretty obvious, but I of course want a second opinion.
Attachment #114858 -
Flags: review?(justdave)
Attachment #114858 -
Flags: review?(bbaetz)
Attachment #114858 -
Flags: review+
|
||
Comment 4•22 years ago
|
||
Comment on attachment 114858 [details] [diff] [review]
The fix
This looks fine. There are various conditionals beow which could do with some
commenting, though.
Attachment #114858 -
Flags: review?(bbaetz)
|
|
Assignee | |
Comment 5•22 years ago
|
||
WRT comment 4:
I'd rather keep this as a "pure" one-liner and handle comment clean-up as a
seperate bug.
Flags: approval?
|
|
||
Comment 6•22 years ago
|
||
Just FYI, I'm not ignoring this, but this is going to sit in "pending approval"
state until we're ready to roll on 2.17.4 because of the security status.
|
|
||
Updated•22 years ago
|
Flags: approval? → approval+
|
|
||
Comment 7•22 years ago
|
||
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi
new revision: 1.182; previous revision: 1.181
done
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in 2.17.4]
|
|
||
Comment 8•22 years ago
|
||
Security Advisory has been posted, removing security group
Group: webtools-security
|
||
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•