Closed Bug 19461 Opened 25 years ago Closed 25 years ago

Abook crashes after Deleting a card then reopening Abook in same session

Categories

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P3)

All
Linux
defect

Tracking

(Not tracked)

VERIFIED WORKSFORME

People

(Reporter: esther, Assigned: chuang)

Details

Attachments

(1 file)

Using linux build 1999112008 m12 I crash if I delete an Address book card, then close the address book then reopen without closing apprunner first. Not sure if this is regression since in earlier releases we couldn't delete a card (16484)on linux. 1. Have at least 3 card in your personal address book (one you can delete) 2. Launch Appruner 3. Select Address Book from the Tasks menu list 4. Select Personal Address Book 5. Select a card you can delete 6. Click the Delete Tool bar button 7. Close Address Book 8. Select Address Book from the Tasks menu list - Crash Result: Crash Expected: Address Book to open Talk back report sent by can't retrieve it yet.
QA Contact: lchiang → esther
Note: this is similar to bug 16483, but that specific scenario (crash after using Edit Card) is fixed and verified, that bug was getting off track so I opened this one.
Talkback incident 1144878 Call Stack ibmork.so + 0x2cb58 (0x40867b58) libmork.so + 0x3eb48 (0x40879b48) libmork.so + 0x2da6c (0x40868a6c) libmork.so + 0x28101 (0x40863101) libmork.so + 0x3a2ed (0x408752ed) libmork.so + 0x396db (0x408746db) libmork.so + 0x22b86 (0x4085db86) libaddrbook.so + 0x23267 (0x40fb5267) libxpcom.so + 0x3634e (0x400c834e) librdf.so + 0x25037 (0x40775037) librdf.so + 0x45ac3 (0x40795ac3) librdf.so + 0x40fb9 (0x40790fb9) librdf.so + 0x41520 (0x40791520) librdf.so + 0x54b97 (0x407a4b97) librdf.so + 0x504fb (0x407a04fb) librdf.so + 0x3c639 (0x4078c639) librdf.so + 0x3a1f6 (0x4078a1f6) librdf.so + 0x62dec (0x407b2dec) libjsdom.so + 0x3e0c2 (0x403c30c2) libmozjs.so + 0x27791 (0x4005e791) libmozjs.so + 0x2da5a (0x40064a5a) libmozjs.so + 0x277ed (0x4005e7ed) libmozjs.so + 0x2da5a (0x40064a5a) libmozjs.so + 0x277ed (0x4005e7ed) libmozjs.so + 0x2da5a (0x40064a5a) libmozjs.so + 0x277ed (0x4005e7ed) libmozjs.so + 0x279b8 (0x4005e9b8) libmozjs.so + 0x1020c (0x4004720c) libjsdom.so + 0x214b5 (0x403a64b5) libjsdom.so + 0x4475e (0x403c975e) libraptorhtml.so + 0x16204d (0x409e604d) librdf.so + 0x3d750 (0x4078d750) librdf.so + 0x62a1d (0x407b2a1d) librdf.so + 0x6204b (0x407b204b) librdf.so + 0x362e1 (0x407862e1) libmozjs.so + 0x27791 (0x4005e791) libmozjs.so + 0x2da5a (0x40064a5a) libmozjs.so + 0x277ed (0x4005e7ed) libmozjs.so + 0x2da5a (0x40064a5a) libmozjs.so + 0x277ed (0x4005e7ed) libmozjs.so + 0x2da5a (0x40064a5a) libmozjs.so + 0x277ed (0x4005e7ed) libmozjs.so + 0x279b8 (0x4005e9b8) libmozjs.so + 0x1020c (0x4004720c) libjsdom.so + 0x214b5 (0x403a64b5) libjsdom.so + 0x4475e (0x403c975e) libraptorhtml.so + 0x16217d (0x409e617d) libjsdom.so + 0x2f412 (0x403b4412) libraptorwebwidget.so + 0x1362d (0x4080962d) libraptorwebwidget.so + 0xbd7d (0x40801d7d) libraptorwebwidget.so + 0xbbc0 (0x40801bc0) libnecko.so + 0x1654a (0x4045a54a) libnecko_file.so + 0x43e6 (0x404693e6) libnecko.so + 0xac44 (0x4044ec44) libnecko.so + 0xa810 (0x4044e810) libplds3.so + 0x1c17 (0x40110c17) libplds3.so + 0x1b86 (0x40110b86) libxpcom.so + 0x5d544 (0x400ef544) libwidget_gtk.so + 0x211e7 (0x404b51e7) libwidget_gtk.so + 0x20dad (0x404b4dad) libglib-1.2.so.0 + 0xe3ca (0x406473ca) libglib-1.2.so.0 + 0xfa86 (0x40648a86) libglib-1.2.so.0 + 0x10041 (0x40649041) libglib-1.2.so.0 + 0x101e1 (0x406491e1) libgtk-1.2.so.0 + 0x8b7a9 (0x405727a9) libwidget_gtk.so + 0x21535 (0x404b5535) libnsappshell.so + 0x11d62 (0x4036ad62) mozilla-bin + 0x26d2 (0x0804a6d2) mozilla-bin + 0x287d (0x0804a87d) libc.so.6 + 0x17cb3 (0x401f5cb3)
Hardware: HP → PC
Status: NEW → ASSIGNED
None of my code is on the stack here, but I'll look into it. I may not be the best person to do this since I can't do much address book stuff with my linux build, but I'll try some more.
Attached patch patch to fix this (deleted) — Splinter Review
OK, I have a fix for this - the problem is that the address book code is closing the mork store without removing the database from the cache. The attached patch removes any closed mdb from the cache, so this won't happen. The other way to fix this is to only actually close the mork store when the database gets deleted, but for some reason, that's not the way the address book database code works.
Assignee: bienvenu → chuang
Status: ASSIGNED → NEW
Reassigning to Candice.
Hardware: PC → All
Summary: [PP]Linux only-Abook crashes after Deleting a card then reopening Abook in same session → Abook crashes after Deleting a card then reopening Abook in same session
I had no problem reproducing this on windows. Changing platform to all and removing PP from summary.
Target Milestone: M12
I didn't get a crash when I tried on my NT using my debug build, 12-01's released build and debug build on my Linux machine. I will try on my Mac debug build once it finish compiling. Esther, can you verify on your machines?
Not happening on 12/01 builds for win98, linux and mac. This can be resolved as worksforme and I will verify.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → VERIFIED
Verified again with 12/08 builds on mac and linux and 12/7 builds on win98
The patch_I_attached fixes_a_real_bug. I think this bug is_the_same_as_22001
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: