Closed
Bug 195502
Opened 22 years ago
Closed 22 years ago
Remove nsPluginViewer.cpp and friends
Categories
(Core Graveyard :: Plug-ins, defect, P4)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.4beta
People
(Reporter: peterlubczynski-bugs, Assigned: peterl-bugs)
Details
(Keywords: memory-footprint)
Attachments
(1 file)
|
(deleted),
patch
|
john
:
review+
alecf
:
superreview+
asa
:
approval1.4b+
|
Details | Diff | Splinter Review |
Because of the fix in bug 90256, nsPluginViewer.cpp and nsPluginDocLoaderFactory.cpp are no longer used. They can be removed.
|
Reporter | |
Updated•22 years ago
|
Priority: -- → P4
Target Milestone: --- → mozilla1.4alpha
|
|
Reporter | |
Comment 1•22 years ago
|
||
This patch removes the old full-page implementation that was deprecated with bug 90256. The following files will be CVS removed: nsIPluginViewer.idl nsPluginViewer.h nsPluginViewer.cpp nsPluginDocLoaderFactory.h nsPluginDocLoaderFactory.cpp
|
|
Reporter | |
Updated•22 years ago
|
Attachment #121214 -
Flags: superreview?(alecf)
Attachment #121214 -
Flags: review?(jkeiser)
|
||
Comment 2•22 years ago
|
||
Comment on attachment 121214 [details] [diff] [review] patch v.1 nice! sr=alecf
Attachment #121214 -
Flags: superreview?(alecf) → superreview+
|
||
Comment 3•22 years ago
|
||
Comment on attachment 121214 [details] [diff] [review] patch v.1 mmm, happiness is.
Attachment #121214 -
Flags: review?(jkeiser) → review+
|
|
Reporter | |
Comment 4•22 years ago
|
||
requesting for 1.4a: this removes dead code that's no longer being used and will reduce embedding code size footprint
Flags: blocking1.4b?
|
|
Reporter | |
Updated•22 years ago
|
Attachment #121214 -
Flags: approval1.4b?
|
||
Comment 5•22 years ago
|
||
Comment on attachment 121214 [details] [diff] [review] patch v.1 a=asa (on behalf of drivers) for checkin to 1.4b.
Attachment #121214 -
Flags: approval1.4b? → approval1.4b+
|
|
||
Comment 6•22 years ago
|
||
approved but not a blocker (we wouldn't hold for this.) setting to blocking1.4b- but don't let that stop you from landing it.
Flags: blocking1.4b? → blocking1.4b-
|
||
Comment 7•22 years ago
|
||
Sweet. This removed something like 18k of embedding footprint. ;)
|
|
Reporter | |
Comment 8•22 years ago
|
||
checked in last night, marking FIXED.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.4alpha → mozilla1.4beta
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•