found in recent builds in both mozilla and netscape. 1. open Preferences window. 2. select the Advanced - Keyboard Navigation pref panel. 3. click the Help button. results: Help window displays the main (home) help page, not a page for keyboard navigation prefs. is this online help info missing (or not written yet)?

--->over to Jatin.

Right, there's no help written for the pref panel yet.

back to me.

As soon as the commercial tree opens, I'll check in the help content to cs_nav_prefs_advanced.html and also update the help TOC file. Next step is for Aaron to hook up the Help button in the prefs panel. To hook up the Help button in the Keyboard Navigation prefs panel, use the following description ID: <rdf:Description ID="advanced_pref_keyboard_nav" nc:name="Keyboard Navigation" nc:link="chrome://help/locale/cs_nav_prefs_advanced.html#keyboard_navigation"/> Re-assigning to Aaron to hook up the Help button in the prefs panel.

Help content updates checked in to commercial trunk. Once the Help button is hooked up, this will work in the commercial trunk. (Mozilla help updates to come later).

*** Bug 194169 has been marked as a duplicate of this bug. ***

Updating summary to reflect what's needed. The help content has been checked in; now we need an engineer to hook up the Help button in the new Keyboard Navigation prefs panel. See comment #4 for details. Re-assigning to Samir. Please re-assign as necessary.

aaron, could you do this?

I haven't been able to get a Netscape build so I can do this. Couldn't get any help from the build team, either.

Aaron, If this is all in XUL you should be able to use an opt build to test modified XUL patches. If you need a debug build, I can work with you to get a commercial build going. Finally, if you are unable to get to this for 1.4 then I can see about reassigning it to someone in my team and bringing it up on adt's triage radar.

adt: nsbeta1+/adt2

ian, would you have a spare cycle to hook up the help here? thanks!

ACCEPTING

sorry, also includes patch for composer hook-up

r=robinf. Thanks Ian!!

yay! see bug 54802 for background info on the composer toolbar stuff.

Comment on attachment 123216 [details] [diff] [review] hooking keynav panel up to help Trivial help hookup patch, has 2 r='s. Doesn't really need sr=.

Comment on attachment 123216 [details] [diff] [review] hooking keynav panel up to help Removing approval request now that I realize this patch is only for the Netscape tree.

Comment on attachment 123259 [details] [diff] [review] Patch for Mozilla tree. Also brings Mozilla's keyboard prefs up to date with Netscape's. Right on, Aaron! Hope Stuttgart is treating you well

Comment on attachment 123259 [details] [diff] [review] Patch for Mozilla tree. Also brings Mozilla's keyboard prefs up to date with Netscape's. I don't think we need sr= for these help file changes, correct?

Comment on attachment 123259 [details] [diff] [review] Patch for Mozilla tree. Also brings Mozilla's keyboard prefs up to date with Netscape's. a=asa (on behalf of drivers) for checkin to 1.4

Mozilla patch checked in. Ian, mark it fixed when your NS patch is checked in.

checked in

vrfy'd fixed with 2003.05.15.12 comm builds.