Closed
Bug 196271
Opened 22 years ago
Closed 22 years ago
[FIX]possible double-delete if SetHTMLAttribute fails in nsDOMCSSAttributeDeclaration::SetCSSDeclaration
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
(Whiteboard: [whitebox])
Attachments
(1 file)
|
(deleted),
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
|
||
Updated•22 years ago
|
Whiteboard: [whitebox]
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Updated•22 years ago
|
Attachment #117171 -
Flags: superreview?(dbaron)
Attachment #117171 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•22 years ago
|
Summary: possible double-delete if SetHTMLAttribute fails in nsDOMCSSAttributeDeclaration::SetCSSDeclaration → [FIX]possible double-delete if SetHTMLAttribute fails in nsDOMCSSAttributeDeclaration::SetCSSDeclaration
|
||
Comment 2•22 years ago
|
||
Comment on attachment 117171 [details] [diff] [review]
Proposed patch.....
r+sr=dbaron, but we should really just get rid of |RuleAbort|, rename
|mRuleRefs| to |mRefCnt|, and use the reference count to deal with ownership.
Attachment #117171 -
Flags: superreview?(dbaron)
Attachment #117171 -
Flags: superreview+
Attachment #117171 -
Flags: review?(dbaron)
Attachment #117171 -
Flags: review+
|
|
Assignee | |
Comment 3•22 years ago
|
||
Yeah, that would be bug 196273.
Fix checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•