It was not included it in my original patch for content view - bug 97062. Hyatt wanted to cache properties instead of parsing them each time, so I changed code a bit to cache properties on rows. Column and cell properties are still not cached anyway. We tried to do something similar for rdfliner, but then we decided to WONFIX it - bug 117988. Now I think it's time to remove it completely, since I'm going to check in a patch which improves painting speed by about 36% - bug 185977

Comment on attachment 116666 [details] [diff] [review] patch Is there a measurable performance win from keeping the property caching, even with your patch for bug 185977?

Brain, Do you remember my testcase for content view ? The test case contains about 30 rows. I added properties attribute on each row: <treerow properties="this-is-long-property and-this-is-another-one"> I see no measurable difference with and without patch applied. It takes 9 ms to paint in both cases. I guess there have to be a difference, but I don't think it's worth.

Comment on attachment 116666 [details] [diff] [review] patch + if (properties.Length()) prefer if (!properties.IsEmpty()) Oh, I just noticed you moved that code from ParseProperties. Could you change it anyway before checking in?

checked in saved 1636 bytes