Closed
Bug 197485
Opened 22 years ago
Closed 22 years ago
Remove [GS]etTransparentColor from gfxIImageFrame
Categories
(Core Graveyard :: GFX, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.4alpha
People
(Reporter: Biesinger, Assigned: Biesinger)
References
()
Details
Attachments
(1 file)
|
(deleted),
patch
|
paper
:
review+
tor
:
superreview+
|
Details | Diff | Splinter Review |
SetTransparentColor has only one caller.
GetTransparentColor has none.
-> I'd like to remove them.
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Updated•22 years ago
|
Attachment #117280 -
Flags: review?(paper)
|
||
Comment 2•22 years ago
|
||
Comment on attachment 117280 [details] [diff] [review]
patch
good riddance :)
Attachment #117280 -
Flags: review?(paper) → review+
|
|
Assignee | |
Comment 3•22 years ago
|
||
Comment on attachment 117280 [details] [diff] [review]
patch
Hi tor - could you super-review this removal of two unneeded functions? it also
saves 4 bytes per gfxImageFrame and a bit of code during gif loading.
Attachment #117280 -
Flags: superreview?(tor)
|
|
Assignee | |
Updated•22 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.4alpha
Attachment #117280 -
Flags: superreview?(tor) → superreview+
|
|
Assignee | |
Comment 4•22 years ago
|
||
Checking in gfx/idl/gfxIImageFrame.idl;
/cvsroot/mozilla/gfx/idl/gfxIImageFrame.idl,v <-- gfxIImageFrame.idl
new revision: 1.11; previous revision: 1.10
done
Checking in gfx/src/shared/gfxImageFrame.cpp;
/cvsroot/mozilla/gfx/src/shared/gfxImageFrame.cpp,v <-- gfxImageFrame.cpp
new revision: 1.22; previous revision: 1.21
done
Checking in gfx/src/shared/gfxImageFrame.h;
/cvsroot/mozilla/gfx/src/shared/gfxImageFrame.h,v <-- gfxImageFrame.h
new revision: 1.6; previous revision: 1.5
done
Checking in modules/libpr0n/decoders/gif/nsGIFDecoder2.cpp;
/cvsroot/mozilla/modules/libpr0n/decoders/gif/nsGIFDecoder2.cpp,v <--
nsGIFDecoder2.cpp
new revision: 1.50; previous revision: 1.49
done
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•