Closed Bug 198487 Opened 22 years ago Closed 19 years ago

libjar needs to check CRC

Categories

(Core :: Networking: File, defect, P1)

x86
Windows 2000
defect

Tracking

()

RESOLVED FIXED
mozilla1.4beta

People

(Reporter: alecf, Assigned: dveditz)

References

Details

(Keywords: regression)

In my libjar rewrite, I forgot to include CRC checking. Doh! We used to do this and we really need to be able to check for valid data in a jar! This bug will track that.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.4beta
Priority: -- → P1
Severity: normal → major
In bug 214672, I'm re-arranging the JArInputStream stuff, and found the problem with the CRC check. Currently it is performed on the 'input' (the compressed item), instead of the 'output' (the original/expanded item).
Depends on: 214672
No longer depends on: 214672
Depends on: 214672
Assignee: alecf → dveditz
Status: ASSIGNED → NEW
Note that bug 214672 contains a complete (and hopefully still uptodate) patch for this and a number of other 'bugs'. If this one is taken up, IMHO best is to start with that one...
With bug 214672 fixed, the CRC checking is now also back online again, so this one can also be closed.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.