Philip K. Warren Assignee
	Description • 22 years ago

On AIX, when characters should be highlighted and underlined, they return a
XIMFeedback style of type XIMHighlight | XIMUnderline (0x3). Mozilla currently
doesn't support this XIMFeedback style (see code below), so all text which is
meant to be shown highlighted and underlined is only underlined.

http://lxr.mozilla.org/seamonkey/source/widget/src/gtk/nsGtkIMEHelper.cpp#298

I have a quick one line patch which fixes this problem.

	Philip K. Warren Assignee
	Comment 1 • 22 years ago

Use style NS_TEXTRANGE_SELECTEDCONVERTEDTEXT for XIMFeedback style XIMHighlight
| XIMUnderline.

	Masaki Katakai
	Comment 2 • 22 years ago

Comment on attachment 118945 [details] [diff] [review]
Patch v1

Let's make default to NS_TEXTRANGE_SELECTEDCONVERTEDTEXT.

      switch (*preeditFeedback++) {
      case XIMReverse:
	*pFeedbackAttr = NS_TEXTRANGE_SELECTEDRAWTEXT;
	break;
      case XIMUnderline:
	*pFeedbackAttr = NS_TEXTRANGE_CONVERTEDTEXT;
	break;
      default:
	*pFeedbackAttr = NS_TEXTRANGE_SELECTEDCONVERTEDTEXT;
      }

	Philip K. Warren Assignee
	Comment 3 • 22 years ago

This would make the NS_TEXTRANGE_RAWINPUT style not be used at all - are you
sure that this is the correct fix?

	Masaki Katakai
	Comment 5 • 22 years ago

Comment on attachment 119476 [details] [diff] [review]
Patch v2

Yes, most IMEs set the style to Underline and Reverse. gtk+2 also only looks
for Underline and Reverse.

We can not handle all possible value of the style other than Underline and
Reverse.
Should be NS_TEXTRANGE_SELECTEDCONVERTEDTEXT,
but not NS_TEXTRANGE_RAWINPUT.

	Christopher Blizzard (:blizzard)
	Comment 6 • 22 years ago

Comment on attachment 119476 [details] [diff] [review]
Patch v2

sr=blizzard

	Philip K. Warren Assignee
	Comment 7 • 22 years ago

Fixed.

Checking in nsGtkIMEHelper.cpp
/cvsroot/mozilla/widget/src/gtk/nsGtkIMEHelper.cpp,v  <--  nsGtkIMEHelper.cpp
new revision: 1.48; previous revision: 1.47
done