As part of removing the global $vars hash, the various Throw*Error functions need to get passed their $vars explcitly, rather than just picking up the global stuff. (Only header_done is excemt from this, for the moment - its a bigger issue to fix) Patch coming after I finish testing it. Also fixes bug 181553 (whcih I noted separately)

Also, I've fixed an incorrect Throw from userprefs.cgi (where we thrw the var name, instead of the template name, and replaced a variables.sortkey with jus sortkey (variables in only in ThrowCodeError, and not for long...) Also fixed an issue in attachment.cgi where we needed to give the bug # in teh error message, but used the attachment number'd error template.

OK, this also removes the example bit from the default templte, and rempves the backwards compat code for using the error tag as the actual message - that all got removed a while back.

Comment on attachment 118879 [details] [diff] [review] patch r=gerv. Looks fine to me. Gerv

Checked in.