Closed Bug 200127 Opened 22 years ago Closed 22 years ago

Standardize on <tree class="focusring"> for trees that want to display focus

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Platform:
x86
Windows 95
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: neil, Assigned: janv)

Details

Attachments

(1 file, 2 obsolete files)

Fixed superreview nits
(deleted), patch
janv
: review+
jag+mozilla
: superreview+
Details | Diff | Splinter Review
Messenger, Venkman and about:config want to display a focus ring on a tree, but each theme currently has to separately skin them for the correct effect.
Oops clicked on the wrong component :-(
Assignee: hyatt → varga
Component: XP Toolkit/Widgets: XUL → XP Toolkit/Widgets: Trees
also XP filepicker
Attached patch Proposed patch (obsolete) (deleted) — — Splinter Review
Comment on attachment 119663 [details] [diff] [review] Proposed patch >- <tree id="folderTree" class="plain" flex="1" seltype="single" >+ <tree id="folderTree" class="plain focusring" flex="1" seltype="single" selstyle="primary" I also have this in my tree, but I don't think it's ready to be checked in :) >+/* ::::: tree focusring ::::: */ >+ >+.focusring > .tree-rows > .tree-bodybox, >+.focusring > .tree-rows > .tree-bodybox { >+ border: 1px solid transparent; >+} >+ >+.focusring:focus > .tree-rows > .tree-bodybox, >+.focusring:focus > .tree-rows > .tree-bodybox { >+ border: 1px solid #000000; >+} >+ copy/paste error ? I think just one rule should make it other than that r=varga
Attachment #119663 - Flags: review+
Attachment #119663 - Flags: review?(varga)
Attachment #119663 - Flags: review?(varga)
Attached patch Fixed review nits (obsolete) (deleted) — — Splinter Review
Attachment #119663 - Attachment is obsolete: true
Comment on attachment 119669 [details] [diff] [review] Fixed review nits Seeking review on venkman portion of patch
Attachment #119669 - Flags: review?(rginda)
Comment on attachment 119669 [details] [diff] [review] Fixed review nits r=rginda for the venkman changes
Attachment #119669 - Flags: review?(rginda) → review+
Attachment #119669 - Flags: superreview?(jaggernaut)
Comment on attachment 119669 [details] [diff] [review] Fixed review nits The change in venkman.css seems suspect. Should the mac classic theme be using -moz-mac-focusring? http://lxr.mozilla.org/seamonkey/search?string=mac-focusring
Attached patch Fixed superreview nits (deleted) — — Splinter Review
I don't know what happened to the venkman.css patch, attachment 119663 [details] [diff] [review] was OK.
Attachment #119669 - Attachment is obsolete: true
Comment on attachment 120079 [details] [diff] [review] Fixed superreview nits Jan, you've got a Mac, right?
Attachment #120079 - Flags: superreview?(jaggernaut)
Attachment #120079 - Flags: review?(varga)
Comment on attachment 120079 [details] [diff] [review] Fixed superreview nits sr=jag
Attachment #120079 - Flags: superreview?(jaggernaut) → superreview+
make it 2px in mac/tree.css r=varga
Fix checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Attachment #120079 - Flags: review?(varga) → review+
Attachment #119669 - Flags: superreview?(jaggernaut)
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: shrir → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: