Closed
Bug 200198
Opened 22 years ago
Closed 22 years ago
user-error.html.tmpl's use [% changedsince %] instead of $changedsince
Categories
(Bugzilla :: Bugzilla-General, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: burnus, Assigned: burnus)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
gerv
:
review+
|
Details | Diff | Splinter Review |
In global/user-error.html.tmpl there is this line: [% ELSIF error == "no_dupe_stats_error_whenever" %] [% title = "Error Reading Previous Dupes File" %] An error occurred opening $changedsince days ago ($whenever)'s Relevant lines from duplicates.cgi: my $changedsince = formvalue("changedsince", 7); my $whenever = days_ago($changedsince); # If error then $vars->{'changedsince'} = $changedsince; $vars->{'whenever'} = $whenever; ThrowUserError("no_dupe_stats_error_whenever"); });
Assignee | ||
Comment 1•22 years ago
|
||
This patch is based on the patch from bug 192677. I use FILTER html though this is not needed since the variables are detained or save, respectively.
Assignee | ||
Updated•22 years ago
|
Attachment #119135 -
Flags: review?(gerv)
Comment 2•22 years ago
|
||
burnus: is this patch still necessary? I'm sure some of it's already gone in... Gerv
Assignee | ||
Comment 3•22 years ago
|
||
> is this patch still necessary? I'm sure some of it's already gone in...
Hmm, I couldn't find any changes (other that duplicates.cgi's patch didn't
apply anymore).
Attachment #119135 -
Attachment is obsolete: true
Assignee | ||
Updated•22 years ago
|
Attachment #121799 -
Flags: review?(gerv)
Assignee | ||
Updated•22 years ago
|
Attachment #119135 -
Flags: review?(gerv)
Comment 4•22 years ago
|
||
Comment on attachment 121799 [details] [diff] [review] Rediff Why does the detaint code have to move 20 lines up the file? Gerv
Assignee | ||
Comment 5•22 years ago
|
||
> Why does the detaint code have to move 20 lines up the file?
|detaint_natural($maxrows)
No particular reason but keeping the two detaints together.
|detaint_natural($changedsince)
Well, I like to detain $changedsince before I use it, since I filter it anyway
in the template, it shouldn't matter though. (Not knowing what exactly might get
wrong in this line: tie(%before, 'AnyDBM_File',
"data/duplicates/dupes$whenever"[...])
This comes between the new and the former location:
my $whenever = days_ago($changedsince);
if (!$!{ENOENT}) {
ThrowUserError("no_dupe_stats_error_whenever",
{ error_msg => $!,
changedsince => $changedsince,
whenever => $whenever,
});
Status: NEW → ASSIGNED
Updated•22 years ago
|
Attachment #121799 -
Flags: review?(gerv) → review+
Assignee | ||
Updated•22 years ago
|
Flags: approval?
Target Milestone: --- → Bugzilla 2.18
Updated•22 years ago
|
Flags: approval? → approval+
Assignee | ||
Comment 6•22 years ago
|
||
Checking in duplicates.cgi; /cvsroot/mozilla/webtools/bugzilla/duplicates.cgi,v <-- duplicates.cgi new revision: 1.37; previous revision: 1.36 done Checking in template/en/default/global/user-error.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v <-- user-error.html.tmpl new revision: 1.35; previous revision: 1.34 done
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•