User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030410 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030410 As of the 4/10-09 build under XP, I am no longer getting native scrollbars (nsITheme) with form elements. (List boxes, etc.) Reproducible: Always Steps to Reproduce:

I see this change on OS X between these two builds I had on hand... 2003040608 - Modern theme uses native widgets for selects 2003041008 - Modern theme uses themed widdtes for selects

this is an intentional change resulting from the patch for bug 126263 marking INVALID

Removing nsITheme may fix the other bug, but it removed the UI that should be in place with all form controls. (Or else that *original* bug should be reopened.) This is still a regression. There should be a fix to reinstate the native scrollbars in form controls that doesn't recreate the other bug.

Note: Classic still retains *its* themed scrollbars in form elements, so there's no reason why Modern should not also.

mkaply, any thoughts on this one?

nsITheme is ONLY used for classic. I'm not sure what you are asking for.

> nsITheme is ONLY used for classic. I'm not sure what you are asking for. Then something truly bizarre is going on. It wasn't until bug 172751 and bug 169373 were checked in that we got any native skinning of form controls in the Modern theme. Since both of these dealt with nsITheme, I find it hard to believe that there was no correlation. Up until bug 126263 was fixed, we had native scrollbars in *all* form controls under Modern. (And it was bug 172751 and bug 169373 that caused form controls to be natively skinned in Modern.) Now, we have native skinning of all form controls *except* scrollbars.

To clarify. I know that the *browser* scrollbars have never been skinned in Modern (that's bug 187916) - but form element scrollbars (listboxes) have been ever since nsITheme was implemented for Win32. The circled scrollbars in the attachment indicate those form elements.

Here's a screenshot clearly showing native skinning of other form elements in modern.

Form element scrollbars were NEVER skinned. They were actually using the platform native scrollbars. This was a MAJOR problem. We switched so that we are using Mozilla scrollbars. These only get skinned on classic. We could certainly take a bug that form scrollbars should always use nsITheme.

> We could certainly take a bug that form scrollbars should always use nsITheme. Then - consider that this bug. <grin> (Otherwise, bug 169373 really should be reopened since it was never completely implemented.) The summary is accurate, and I won't reinstate the "regression" keyword since, technically, it's not correct.

I think that before anything else is changed, someone needs to make a definitive decision on whether form elements should use the OS theme or the Mozilla theme. Otherwise this will be like the toolbar grippies, being changed one way by someone and then changed back by someone else.

CCing Hyatt since he was involved in the original checkin for using nsITheme in form controls. If his work had nothing to do with listbox scrollbars changing to being natively skinned, perhaps he's aware of the coincidental checkin that did cause this to happen at the same time.

Not sure if this is the right place to post this, but: Mozilla 1.4b skins almost all form elemets in Modern theme except for the arrow for single drop down lists. Screenshot to be posted.

Screenshot for my previous comment.

> Mozilla 1.4b skins almost all form elemets in Modern theme except for the > arrow for single drop down lists. No, all elements (including the single drop down list arrow) are being skinned by the Windows OS - except for form scrollbars. I can change the Windows theme I'm using, and everything in Mozilla forms will change, except for the form scrollbars.

(Attachment 120206 [details] shows every other form element using the native Windows theme rather that being skinned by Mozilla.)

You're right. The radio buttons and checkboxes are also skinned. However, the scrollbars themselves are not being skinned, whether they are in the main browser window or a textarea or a drop-down list. However, Mozilla allows "skinning" of buttons through CSS (which is the correct behaviour).

This change/bug is a regression from 1.3[.1], which did correctly theme scrollbars in Modern. Screenshot from 1.3.1 coming up in a sec. Compare to attachment 122969 [details] from Max, to see why this bug makes form scrollbars look very odd under XP with the Modern theme.

Compare to attachment 122969 [details] from Max how it currrently looks on the trunk

eberry, unless I am mistaken, this bug is specifically for using the Modern theme to skin everything, including the scroll bars and the form elements. I believe bug 187916 is specifically for skinning using nsiTheme, not Modern, which is where you should post.

To clarify: This bug is only about skinning form element scrollbars with the native Windows theme. Bug 187916 is only about skinning the main Mozilla scrollbars with the native Windows theme.

Thanks for that much-needed clarification. Based on the clarification, it seems that in fact these two bugs are pretty much the same and I think that the two should be combined into one. It would look weird if form elements were skinned using the native theme while the main scroll bar was not. I think that the best solution would be to create a separate theme (another version of Modern) that will use native scroll bars, etc completely and make the over version skinned completely though nslTheme. However, I think that Mozilla should allow skinning of form elements through style sheets fully - and the settings in the style sheets would be used before those settings set in the theme. This works right now, I think.

MASS-CHANGE: This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state. If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way. If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar). If no action happens within the next few months, we move this bug report to an EXPIRED state. Query tag for this change: mass-UNCONFIRM-20090614

MASS-CHANGE: This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago. Because of this, we're resolving the bug as EXPIRED. If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component. Query tag for this change: EXPIRED-20100420